On Thu, Apr 21, 2022 at 03:48:08PM +0200, Uwe Kleine-König wrote: > Hello, > > On Thu, Apr 21, 2022 at 12:17:00PM +0200, AngeloGioacchino Del Regno wrote: > > Il 18/04/22 14:20, xinlei.lee@mediatek.com ha scritto: > > > From: Xinlei Lee > > > > > > Add interrupts property of pwm for MediaTek MT8192 SoC. > > > > > > Signed-off-by: Xinlei Lee > > > > Hello Xinlei, > > the pwm-mtk-disp.c driver does not support interrupts. > > > > Please add interrupts support to the driver first, and only then > > add that in the dt-bindings. > > in my understanding the linux driver state and the binding documentation > are somewhat independent. Here I'd say adding the irq information to dt > without the driver supporting it is fine. Agreed. I've applied this along with the rest. It doesn't have Rob's or Krzysztof's stamp of approval, but it's a trivial change and looks fine to me. Thierry