On 18.05.2022 16:33:58, Oliver Hartkopp wrote: > > > > And what about the LEDS support depending on BROKEN? > > > > That was introduced by commit 30f3b42147ba6f ("can: mark led trigger as > > > > broken") from Uwe as it seems there were some changes in 2018. > > > > > > There's a proper generic LED trigger now for network devices. So remove > > > LED triggers, too. > > > > Yes, the broken LED topic also popped-up last year: > > > > https://lore.kernel.org/linux-can/20210906143057.zrpor5fkh67uqwi2@pengutronix.de/ > I am OK to add one patch to the series for LED removal. > > Hm. We have several drivers that support LED triggers: > > $ git grep led.h > at91_can.c:#include > c_can/c_can_main.c:#include > ctucanfd/ctucanfd_base.c:#include > dev/dev.c:#include > flexcan/flexcan-core.c:#include > led.c:#include > m_can/m_can.h:#include > rcar/rcar_can.c:#include > rcar/rcar_canfd.c:#include > sja1000/sja1000.c:#include > spi/hi311x.c:#include > spi/mcp251x.c:#include > sun4i_can.c:#include > ti_hecc.c:#include > usb/mcba_usb.c:#include > usb/usb_8dev.c:#include > xilinx_can.c:#include > > And I personally like the ability to be able to fire some LEDS (either as > GPIO or probably in a window manager). > > I would suggest to remove the Kconfig entry but not all the code inside the > drivers, so that a volunteer can convert the LED support based on the > existing trigger points in the drivers code later. The generic netdev LED trigger code doesn't need any support in the netdev driver. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |