Hello,
Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support.
Patch made against 2.6.32-rc6 kernel.
------------------------------------------
--
Best regards
Andrey A. Porodko
Hello,
On Thu, Nov 26, 2009 at 18:36:38, A. Porodko wrote:
> Hello,
>
> Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support.
> Patch made against 2.6.32-rc6 kernel.
> ------------------------------------------
>
> --
> Best regards
> Andrey A. Porodko
>
>
>
@@ -246,6 +249,9 @@ static int __init evm_init(void)
if (machine_is_davinci_evm()) {
evm_snd_dev_data = &evm_snd_devdata;
index = 0;
+ } else if (machine_is_neuros_osd2()) {
+ evm_snd_dev_data = &evm_snd_devdata;
+ index = 0;
The above can be combined with the check for DaVinci EVM
if (machine_is_davinci_evm() ||
(machine_is_neuros_osd2()) {
evm_snd_dev_data = &evm_snd_devdata;
index = 0;
Regards,
Chaithrika
On Thu, Nov 26, 2009 at 06:57:19PM +0530, Chaithrika U S wrote:
> @@ -246,6 +249,9 @@ static int __init evm_init(void)
> if (machine_is_davinci_evm()) {
> evm_snd_dev_data = &evm_snd_devdata;
> index = 0;
> + } else if (machine_is_neuros_osd2()) {
> + evm_snd_dev_data = &evm_snd_devdata;
> + index = 0;
> The above can be combined with the check for DaVinci EVM
> if (machine_is_davinci_evm() ||
> (machine_is_neuros_osd2()) {
> evm_snd_dev_data = &evm_snd_devdata;
> index = 0;
I raised the same query when Andrey sent an off-list copy to me by
mistake - he said that in future he intends to extend the driver to
have additional features not present on the EVM (though for me that
could always change the || later).
Andrey, with Linux kernel patches reply to all is generally the way
forward.
Mark Brown wrote:
> On Thu, Nov 26, 2009 at 06:57:19PM +0530, Chaithrika U S wrote:
>
>
>> @@ -246,6 +249,9 @@ static int __init evm_init(void)
>> if (machine_is_davinci_evm()) {
>> evm_snd_dev_data = &evm_snd_devdata;
>> index = 0;
>> + } else if (machine_is_neuros_osd2()) {
>> + evm_snd_dev_data = &evm_snd_devdata;
>> + index = 0;
>>
>
>
>> The above can be combined with the check for DaVinci EVM
>> if (machine_is_davinci_evm() ||
>> (machine_is_neuros_osd2()) {
>> evm_snd_dev_data = &evm_snd_devdata;
>> index = 0;
>>
>
> I raised the same query when Andrey sent an off-list copy to me by
> mistake - he said that in future he intends to extend the driver to
> have additional features not present on the EVM (though for me that
> could always change the || later).
>
> Andrey, with Linux kernel patches reply to all is generally the way
> forward.
>
Mark,
Understood. Shall I change if if to if || then?
--
Best regards
Andrey A. Porodko
On Fri, Nov 27, 2009 at 06:14:26PM +0500, A. Porodko wrote:
> Mark Brown wrote:
> > I raised the same query when Andrey sent an off-list copy to me by
> > mistake - he said that in future he intends to extend the driver to
> > have additional features not present on the EVM (though for me that
> > could always change the || later).
> Understood. Shall I change if if to if || then?
Honestly I'm not that bothered, I was mostly following up to the list so
that readers and the archives could see the answer to the query (I
guessed you may have mistakenly replied off list).
On Thu, Nov 26, 2009 at 06:06:38PM +0500, A. Porodko wrote:
> Hello,
>
> Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support.
> Patch made against 2.6.32-rc6 kernel.
This doesn't apply against current ASoC. Could you please regenerate
against this branch:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33
Mark Brown wrote:
> On Thu, Nov 26, 2009 at 06:06:38PM +0500, A. Porodko wrote:
>
>> Hello,
>>
>> Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support.
>> Patch made against 2.6.32-rc6 kernel.
>>
>
> This doesn't apply against current ASoC. Could you please regenerate
> against this branch:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33
>
>
Mark Brown wrote:
> On Thu, Nov 26, 2009 at 06:06:38PM +0500, A. Porodko wrote:
>
>> Hello,
>>
>> Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support.
>> Patch made against 2.6.32-rc6 kernel.
>>
>
> This doesn't apply against current ASoC. Could you please regenerate
> against this branch:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33
>
>
Hi,
I wish I knew how to do this. I'm new with git and anly learn how to
work with one tree.
Complex operations confuse me a little. I generated something, but it
doesn't look different from what I had before.
P.S. Reading alsa-project wiki didn't shed more light. For my main tree
is davinci tree and git is damn tricky.
---------------------------
>From 699bbf676a3e74989063b398ff662fcf40469a16 Mon Sep 17 00:00:00 2001
From: Andrey Porodko <[email protected]>
Date: Mon, 23 Nov 2009 13:56:53 +0500
Subject: [PATCH] Davinci sound soc driver patch for Neuros OSD2 board
support.
Signed-off-by: Andrey Porodko <[email protected]>
---
sound/soc/davinci/davinci-evm.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/sound/soc/davinci/davinci-evm.c
b/sound/soc/davinci/davinci-evm.c
index 67414f6..ffdd30e 100644
--- a/sound/soc/davinci/davinci-evm.c
+++ b/sound/soc/davinci/davinci-evm.c
@@ -55,6 +55,9 @@ static int evm_hw_params(struct snd_pcm_substream
*substream,
else if (machine_is_davinci_evm())
sysclk = 12288000;
+ else if (machine_is_neuros_osd2())
+ sysclk = 27000000;
+
else if (machine_is_davinci_da830_evm() ||
machine_is_davinci_da850_evm())
sysclk = 24576000;
@@ -246,6 +249,9 @@ static int __init evm_init(void)
if (machine_is_davinci_evm()) {
evm_snd_dev_data = &evm_snd_devdata;
index = 0;
+ } else if (machine_is_neuros_osd2()) {
+ evm_snd_dev_data = &evm_snd_devdata;
+ index = 0;
} else if (machine_is_davinci_dm355_evm()) {
evm_snd_dev_data = &evm_snd_devdata;
index = 1;
--
1.5.6.5
-----------------------------------------
--
Best regards
Andrey A. Porodko
--
Best regards
Andrey A. Porodko
Mark Brown wrote:
> On Thu, Nov 26, 2009 at 06:06:38PM +0500, A. Porodko wrote:
>
>> Hello,
>>
>> Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support.
>> Patch made against 2.6.32-rc6 kernel.
>>
>
> This doesn't apply against current ASoC. Could you please regenerate
> against this branch:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33
>
>
Hi Mark,
Are you sure you have the latest davinci soc support in your tree?
Mine file davinci_evm.c is 7.5k size, in your
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git
repo your is 5.5k. Quick glance shows that in your repo davinci support
lacks of da830_evm support.
I'm confused which one is I have to use and apply patch to?
--
Best regards
Andrey A. Porodko
Andrey A. Porodko wrote:
Please, disregard my previous message. It's me stupid enough to forget
to switch to the right branch.
Sorry.
> Mark Brown wrote:
>
>> On Thu, Nov 26, 2009 at 06:06:38PM +0500, A. Porodko wrote:
>>
>>
>>> Hello,
>>>
>>> Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support.
>>> Patch made against 2.6.32-rc6 kernel.
>>>
>>>
>> This doesn't apply against current ASoC. Could you please regenerate
>> against this branch:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33
>>
>>
>>
> Hi Mark,
>
> Are you sure you have the latest davinci soc support in your tree?
> Mine file davinci_evm.c is 7.5k size, in your
>
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git
>
> repo your is 5.5k. Quick glance shows that in your repo davinci support
> lacks of da830_evm support.
> I'm confused which one is I have to use and apply patch to?
>
>
--
Best regards
Andrey A. Porodko