On 25/11/2022 08:06, Sriranjani P wrote:
> Add compatible for Tesla SYSREG controllers found on FSD SoC.
>
> Signed-off-by: Sriranjani P <[email protected]>
> ---
Thank you for your patch. There is something to discuss/improve.
> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 4e4baf53796d..8c3334999bec 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -69,6 +69,7 @@ properties:
> - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> + - tesla,fsd-sysreg
I think we made mistake starting from 5433. Before (Exynos3/4/5) there
was only one block called actually SYSREG. For example on Exynos5433 we
have SYSREG_DISP, SYSREG_CAM1 and so on. These are different so we
should have dedicated compatibles. The same for Tesla - please provide
dedicated compatibles per each block.
I'll fix Exynos5433. Maybe someone can also fix Exynos850 and Autov9.
Best regards,
Krzysztof
On 25/11/2022 12:29, Krzysztof Kozlowski wrote:
> On 25/11/2022 08:06, Sriranjani P wrote:
>> Add compatible for Tesla SYSREG controllers found on FSD SoC.
>>
>> Signed-off-by: Sriranjani P <[email protected]>
>> ---
>
> Thank you for your patch. There is something to discuss/improve.
>
>> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> index 4e4baf53796d..8c3334999bec 100644
>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> @@ -69,6 +69,7 @@ properties:
>> - samsung,exynos5433-sysreg
>> - samsung,exynos850-sysreg
>> - samsung,exynosautov9-sysreg
>> + - tesla,fsd-sysreg
>
> I think we made mistake starting from 5433. Before (Exynos3/4/5) there
> was only one block called actually SYSREG. For example on Exynos5433 we
> have SYSREG_DISP, SYSREG_CAM1 and so on. These are different so we
> should have dedicated compatibles. The same for Tesla - please provide
> dedicated compatibles per each block.
>
> I'll fix Exynos5433. Maybe someone can also fix Exynos850 and Autov9.
To clarify - in case of Tesla, you do not need the fallbacks, so you
just add few of:
- tesla,fsd-xxx-sysreg
within the enum.
For Exynos850 and Autov9, just like for Exynso5433, we should keep it
backwards compatible, so we need fallbacks.
Best regards,
Krzysztof
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:[email protected]]
> Sent: 25 November 2022 17:10
> To: Sriranjani P <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; Sam Protsenko
> <[email protected]>; Chanho Park
> <[email protected]>
> Cc: [email protected]
> Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add tesla compatibles
> found on FSD SoC
>
> On 25/11/2022 12:29, Krzysztof Kozlowski wrote:
> > On 25/11/2022 08:06, Sriranjani P wrote:
> >> Add compatible for Tesla SYSREG controllers found on FSD SoC.
> >>
> >> Signed-off-by: Sriranjani P <[email protected]>
> >> ---
> >
> > Thank you for your patch. There is something to discuss/improve.
> >
> >> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> >> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> >> index 4e4baf53796d..8c3334999bec 100644
> >> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> >> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> >> @@ -69,6 +69,7 @@ properties:
> >> - samsung,exynos5433-sysreg
> >> - samsung,exynos850-sysreg
> >> - samsung,exynosautov9-sysreg
> >> + - tesla,fsd-sysreg
> >
> > I think we made mistake starting from 5433. Before (Exynos3/4/5) there
> > was only one block called actually SYSREG. For example on Exynos5433
> > we have SYSREG_DISP, SYSREG_CAM1 and so on. These are different so we
> > should have dedicated compatibles. The same for Tesla - please provide
> > dedicated compatibles per each block.
> >
> > I'll fix Exynos5433. Maybe someone can also fix Exynos850 and Autov9.
>
> To clarify - in case of Tesla, you do not need the fallbacks, so you just add few
> of:
> - tesla,fsd-xxx-sysreg
> within the enum.
Thanks for improvement idea and clarification. I'll update accordingly in the
next version.
>
> For Exynos850 and Autov9, just like for Exynso5433, we should keep it
> backwards compatible, so we need fallbacks.
I will update for Exynos850 and Autov9 as like Exynos5433 and post the patch.
>
> Best regards,
> Krzysztof
Thank you.