2020-04-18 07:56:07

by Jason Yan

Subject: [PATCH] KVM: s390: remove unneeded semicolon in gisa_vcpu_kicker()

Fix the following coccicheck warning:

arch/s390/kvm/interrupt.c:3085:2-3: Unneeded semicolon

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
arch/s390/kvm/interrupt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
index 8191106bf7b9..559177123d0f 100644
--- a/arch/s390/kvm/interrupt.c
+++ b/arch/s390/kvm/interrupt.c
@@ -3082,7 +3082,7 @@ static enum hrtimer_restart gisa_vcpu_kicker(struct hrtimer *timer)
__airqs_kick_single_vcpu(kvm, pending_mask);
hrtimer_forward_now(timer, ns_to_ktime(gi->expires));
return HRTIMER_RESTART;
- };
+ }

return HRTIMER_NORESTART;
}
--
2.21.1

2020-04-20 06:49:33

by Cornelia Huck

Subject: Re: [PATCH] KVM: s390: remove unneeded semicolon in gisa_vcpu_kicker()

On Sat, 18 Apr 2020 16:19:26 +0800
Jason Yan <[email protected]> wrote:

> Fix the following coccicheck warning:
>
> arch/s390/kvm/interrupt.c:3085:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>

Fixes: 9f30f6216378 ("KVM: s390: add gib_alert_irq_handler()")

> ---
> arch/s390/kvm/interrupt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 8191106bf7b9..559177123d0f 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -3082,7 +3082,7 @@ static enum hrtimer_restart gisa_vcpu_kicker(struct hrtimer *timer)
> __airqs_kick_single_vcpu(kvm, pending_mask);
> hrtimer_forward_now(timer, ns_to_ktime(gi->expires));
> return HRTIMER_RESTART;
> - };
> + }
>
> return HRTIMER_NORESTART;
> }

Reviewed-by: Cornelia Huck <[email protected]>

2020-04-20 07:07:18

by David Hildenbrand

Subject: Re: [PATCH] KVM: s390: remove unneeded semicolon in gisa_vcpu_kicker()

On 18.04.20 10:19, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> arch/s390/kvm/interrupt.c:3085:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> arch/s390/kvm/interrupt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 8191106bf7b9..559177123d0f 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -3082,7 +3082,7 @@ static enum hrtimer_restart gisa_vcpu_kicker(struct hrtimer *timer)
> __airqs_kick_single_vcpu(kvm, pending_mask);
> hrtimer_forward_now(timer, ns_to_ktime(gi->expires));
> return HRTIMER_RESTART;
> - };
> + }
>
> return HRTIMER_NORESTART;
> }
>

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb

2020-04-20 07:35:52

by Christian Borntraeger

Subject: Re: [PATCH] KVM: s390: remove unneeded semicolon in gisa_vcpu_kicker()

On 18.04.20 10:19, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> arch/s390/kvm/interrupt.c:3085:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>

Thanks applied.

> ---
> arch/s390/kvm/interrupt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 8191106bf7b9..559177123d0f 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -3082,7 +3082,7 @@ static enum hrtimer_restart gisa_vcpu_kicker(struct hrtimer *timer)
> __airqs_kick_single_vcpu(kvm, pending_mask);
> hrtimer_forward_now(timer, ns_to_ktime(gi->expires));
> return HRTIMER_RESTART;
> - };
> + }
>
> return HRTIMER_NORESTART;
> }
>