2020-07-15 09:36:34

by Nishant Malpani

Subject: [PATCH 2/2] dt-bindings: iio: gyro: Add DT binding doc for ADXRS290

Add devicetree binding document for ADXRS290, a dual-axis MEMS gyroscope.

Signed-off-by: Nishant Malpani <[email protected]>
---
.../bindings/iio/gyroscope/adi,adxrs290.yaml | 52 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 53 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml

diff --git a/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml b/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
new file mode 100644
index 000000000000..a997d945fdb0
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright 2020 Analog Devices Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/gyroscope/adi,adxrs290.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices ADXRS290 Dual-Axis MEMS Gyroscope
+
+maintainers:
+ - Nishant Malpani <[email protected]>
+
+description: |
+ Bindings for the Analog Devices ADXRS290 dual-axis MEMS gyroscope device.
+ https://www.analog.com/media/en/technical-documentation/data-sheets/ADXRS290.pdf
+
+properties:
+ compatible:
+ enum:
+ - adi,adxrs290
+
+ reg:
+ maxItems: 1
+
+ spi-max-frequency:
+ maximum: 5000000
+
+ spi-cpol: true
+
+ spi-cpha: true
+
+required:
+ - compatible
+ - reg
+ - spi-max-frequency
+ - spi-cpol
+ - spi-cpha
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ gyro@0 {
+ compatible = "adi,adxrs290";
+ reg = <0>;
+ spi-max-frequency = <5000000>;
+ spi-cpol;
+ spi-cpha;
+ };
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index dd02cfc410e8..0bb8ac90fba1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1103,6 +1103,7 @@ M: Nishant Malpani <[email protected]>
L: [email protected]
S: Supported
F: drivers/iio/gyro/adxrs290.c
+F: Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml

ANALOG DEVICES INC ASOC CODEC DRIVERS
M: Lars-Peter Clausen <[email protected]>
--
2.20.1

2020-07-20 11:19:18

by Jonathan Cameron

Subject: Re: [PATCH 2/2] dt-bindings: iio: gyro: Add DT binding doc for ADXRS290

On Wed, 15 Jul 2020 14:58:21 +0530
Nishant Malpani <[email protected]> wrote:

> Add devicetree binding document for ADXRS290, a dual-axis MEMS gyroscope.
>
> Signed-off-by: Nishant Malpani <[email protected]>
> ---
> .../bindings/iio/gyroscope/adi,adxrs290.yaml | 52 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml b/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
> new file mode 100644
> index 000000000000..a997d945fdb0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2020 Analog Devices Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/gyroscope/adi,adxrs290.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices ADXRS290 Dual-Axis MEMS Gyroscope
> +
> +maintainers:
> + - Nishant Malpani <[email protected]>
> +
> +description: |
> + Bindings for the Analog Devices ADXRS290 dual-axis MEMS gyroscope device.
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ADXRS290.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - adi,adxrs290

I think we can use const here as only one item currently.

> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 5000000
> +
> + spi-cpol: true
> +
> + spi-cpha: true
> +
> +required:
> + - compatible
> + - reg
> + - spi-max-frequency
> + - spi-cpol
> + - spi-cpha
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gyro@0 {
> + compatible = "adi,adxrs290";
> + reg = <0>;
> + spi-max-frequency = <5000000>;
> + spi-cpol;
> + spi-cpha;
> + };
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dd02cfc410e8..0bb8ac90fba1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1103,6 +1103,7 @@ M: Nishant Malpani <[email protected]>
> L: [email protected]
> S: Supported
> F: drivers/iio/gyro/adxrs290.c
> +F: Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
>
> ANALOG DEVICES INC ASOC CODEC DRIVERS
> M: Lars-Peter Clausen <[email protected]>

2020-07-21 02:42:03

by Rob Herring (Arm)

Subject: Re: [PATCH 2/2] dt-bindings: iio: gyro: Add DT binding doc for ADXRS290

On Mon, Jul 20, 2020 at 12:16:33PM +0100, Jonathan Cameron wrote:
> On Wed, 15 Jul 2020 14:58:21 +0530
> Nishant Malpani <[email protected]> wrote:
>
> > Add devicetree binding document for ADXRS290, a dual-axis MEMS gyroscope.
> >
> > Signed-off-by: Nishant Malpani <[email protected]>
> > ---
> > .../bindings/iio/gyroscope/adi,adxrs290.yaml | 52 +++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 53 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml b/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
> > new file mode 100644
> > index 000000000000..a997d945fdb0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright 2020 Analog Devices Inc.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/gyroscope/adi,adxrs290.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices ADXRS290 Dual-Axis MEMS Gyroscope
> > +
> > +maintainers:
> > + - Nishant Malpani <[email protected]>
> > +
> > +description: |
> > + Bindings for the Analog Devices ADXRS290 dual-axis MEMS gyroscope device.
> > + https://www.analog.com/media/en/technical-documentation/data-sheets/ADXRS290.pdf
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - adi,adxrs290
>
> I think we can use const here as only one item currently.

Yep. Really depends if you expect to add more.

>
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + spi-max-frequency:
> > + maximum: 5000000
> > +
> > + spi-cpol: true
> > +
> > + spi-cpha: true
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - spi-max-frequency
> > + - spi-cpol
> > + - spi-cpha

Add:

additionalProperties: false

> > +
> > +examples:
> > + - |
> > + spi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + gyro@0 {
> > + compatible = "adi,adxrs290";
> > + reg = <0>;
> > + spi-max-frequency = <5000000>;
> > + spi-cpol;
> > + spi-cpha;
> > + };
> > + };
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index dd02cfc410e8..0bb8ac90fba1 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1103,6 +1103,7 @@ M: Nishant Malpani <[email protected]>
> > L: [email protected]
> > S: Supported
> > F: drivers/iio/gyro/adxrs290.c
> > +F: Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
> >
> > ANALOG DEVICES INC ASOC CODEC DRIVERS
> > M: Lars-Peter Clausen <[email protected]>
>

2020-07-21 19:13:39

by Nishant Malpani

Subject: Re: [PATCH 2/2] dt-bindings: iio: gyro: Add DT binding doc for ADXRS290

Hello Jonathon & Rob,

Thanks for the review. Comments inline...

On 21/07/20 8:11 am, Rob Herring wrote:
> On Mon, Jul 20, 2020 at 12:16:33PM +0100, Jonathan Cameron wrote:
>> On Wed, 15 Jul 2020 14:58:21 +0530
>> Nishant Malpani <[email protected]> wrote:
>>
>>> Add devicetree binding document for ADXRS290, a dual-axis MEMS gyroscope.
>>>
>>> Signed-off-by: Nishant Malpani <[email protected]>
>>> ---
>>> .../bindings/iio/gyroscope/adi,adxrs290.yaml | 52 +++++++++++++++++++
>>> MAINTAINERS | 1 +
>>> 2 files changed, 53 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml b/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
>>> new file mode 100644
>>> index 000000000000..a997d945fdb0
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
>>> @@ -0,0 +1,52 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +# Copyright 2020 Analog Devices Inc.
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/iio/gyroscope/adi,adxrs290.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Analog Devices ADXRS290 Dual-Axis MEMS Gyroscope
>>> +
>>> +maintainers:
>>> + - Nishant Malpani <[email protected]>
>>> +
>>> +description: |
>>> + Bindings for the Analog Devices ADXRS290 dual-axis MEMS gyroscope device.
>>> + https://www.analog.com/media/en/technical-documentation/data-sheets/ADXRS290.pdf
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - adi,adxrs290
>>
>> I think we can use const here as only one item currently.
>
> Yep. Really depends if you expect to add more.
>
I'm not aware if we'll be adding more. For now, made it a 'const' in v2.

>>
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + spi-max-frequency:
>>> + maximum: 5000000
>>> +
>>> + spi-cpol: true
>>> +
>>> + spi-cpha: true
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - spi-max-frequency
>>> + - spi-cpol
>>> + - spi-cpha
>
> Add:
>
> additionalProperties: false
>
Okay. Acked in v2.

Regards,
Nishant Malpani

>>> +
>>> +examples:
>>> + - |
>>> + spi {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + gyro@0 {
>>> + compatible = "adi,adxrs290";
>>> + reg = <0>;
>>> + spi-max-frequency = <5000000>;
>>> + spi-cpol;
>>> + spi-cpha;
>>> + };
>>> + };
>>> +...
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index dd02cfc410e8..0bb8ac90fba1 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1103,6 +1103,7 @@ M: Nishant Malpani <[email protected]>
>>> L: [email protected]
>>> S: Supported
>>> F: drivers/iio/gyro/adxrs290.c
>>> +F: Documentation/devicetree/bindings/iio/gyroscope/adi,adxrs290.yaml
>>>
>>> ANALOG DEVICES INC ASOC CODEC DRIVERS
>>> M: Lars-Peter Clausen <[email protected]>
>>