2020-09-02 16:19:11

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 1/2] dt-bindings: mfd: syscon: Merge Samsung Exynos Sysreg bindings

The Samsung Exynos System Registers (Sysreg) bindings are quite simple -
just additional compatible to the syscon. They do not have any value so
merge them into generic MFD syscon bindings.

Suggested-by: Sylwester Nawrocki <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. New patch
---
.../bindings/arm/samsung/sysreg.yaml | 45 -------------------
.../devicetree/bindings/mfd/syscon.yaml | 2 +
2 files changed, 2 insertions(+), 45 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/samsung/sysreg.yaml

diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.yaml b/Documentation/devicetree/bindings/arm/samsung/sysreg.yaml
deleted file mode 100644
index 3b7811804cb4..000000000000
--- a/Documentation/devicetree/bindings/arm/samsung/sysreg.yaml
+++ /dev/null
@@ -1,45 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/arm/samsung/sysreg.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Samsung S5P/Exynos SoC series System Registers (SYSREG)
-
-maintainers:
- - Krzysztof Kozlowski <[email protected]>
-
-# Custom select to avoid matching all nodes with 'syscon'
-select:
- properties:
- compatible:
- contains:
- enum:
- - samsung,exynos4-sysreg
- - samsung,exynos5-sysreg
- required:
- - compatible
-
-properties:
- compatible:
- allOf:
- - items:
- - enum:
- - samsung,exynos4-sysreg
- - samsung,exynos5-sysreg
- - const: syscon
-
- reg:
- maxItems: 1
-
-examples:
- - |
- syscon@10010000 {
- compatible = "samsung,exynos4-sysreg", "syscon";
- reg = <0x10010000 0x400>;
- };
-
- syscon@10050000 {
- compatible = "samsung,exynos5-sysreg", "syscon";
- reg = <0x10050000 0x5000>;
- };
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 049ec2ffc7f9..a34c9e2ab1ca 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -40,6 +40,8 @@ properties:
- allwinner,sun50i-a64-system-controller
- microchip,sparx5-cpu-syscon
- mstar,msc313-pmsleep
+ - samsung,exynos4-sysreg
+ - samsung,exynos5-sysreg

- const: syscon

--
2.17.1


2020-09-02 16:59:23

by Sylwester Nawrocki

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Merge Samsung Exynos Sysreg bindings

On 02.09.2020 18:14, Krzysztof Kozlowski wrote:
> The Samsung Exynos System Registers (Sysreg) bindings are quite simple -
> just additional compatible to the syscon. They do not have any value so
> merge them into generic MFD syscon bindings.
>
> Suggested-by: Sylwester Nawrocki <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Sylwester Nawrocki <[email protected]>

2020-09-09 07:17:08

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Merge Samsung Exynos Sysreg bindings

On Wed, 02 Sep 2020, Krzysztof Kozlowski wrote:

> The Samsung Exynos System Registers (Sysreg) bindings are quite simple -
> just additional compatible to the syscon. They do not have any value so
> merge them into generic MFD syscon bindings.
>
> Suggested-by: Sylwester Nawrocki <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. New patch
> ---
> .../bindings/arm/samsung/sysreg.yaml | 45 -------------------
> .../devicetree/bindings/mfd/syscon.yaml | 2 +
> 2 files changed, 2 insertions(+), 45 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/samsung/sysreg.yaml

Applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

2020-09-14 20:26:34

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Merge Samsung Exynos Sysreg bindings

On Wed, 02 Sep 2020 18:14:51 +0200, Krzysztof Kozlowski wrote:
> The Samsung Exynos System Registers (Sysreg) bindings are quite simple -
> just additional compatible to the syscon. They do not have any value so
> merge them into generic MFD syscon bindings.
>
> Suggested-by: Sylwester Nawrocki <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. New patch
> ---
> .../bindings/arm/samsung/sysreg.yaml | 45 -------------------
> .../devicetree/bindings/mfd/syscon.yaml | 2 +
> 2 files changed, 2 insertions(+), 45 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/samsung/sysreg.yaml
>

Reviewed-by: Rob Herring <[email protected]>