2018-05-13 20:06:08

by Samuel Thibault

Subject: [PATCH] staging: speakup: Fix coding style

Signed-off-by: Samuel Thibault <[email protected]>
---
drivers/staging/speakup/buffers.c | 3 ++-
drivers/staging/speakup/main.c | 5 ++---
2 files changed, 4 insertions(+), 4 deletions(-)

--- a/drivers/staging/speakup/buffers.c
+++ b/drivers/staging/speakup/buffers.c
@@ -78,7 +78,8 @@ void synth_buffer_add(u16 ch)
if (buff_in > buffer_end)
buff_in = synth_buffer;
/* We have written something to the speech synthesis, so we are not
- * paused any more. */
+ * paused any more.
+ */
spk_paused = 0;
}

--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -68,7 +68,7 @@ int spk_punc_level, spk_reading_punc;
char spk_str_caps_start[MAXVARLEN + 1] = "\0";
char spk_str_caps_stop[MAXVARLEN + 1] = "\0";
char spk_str_pause[MAXVARLEN + 1] = "\0";
-bool spk_paused = 0;
+bool spk_paused;
const struct st_bits_data spk_punc_info[] = {
{"none", "", 0},
{"some", "/$%&@", SOME},
@@ -1782,8 +1782,7 @@ static void speakup_con_update(struct vc
/* Speakup output, discard */
return;
speakup_date(vc);
- if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0])
- {
+ if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0]) {
synth_printf("%s", spk_str_pause);
spk_paused = 1;
}

2018-05-13 21:49:36

by Joe Perches

Subject: Re: [PATCH] staging: speakup: Fix coding style

On Sun, 2018-05-13 at 11:38 +0200, Samuel Thibault wrote:
[]
> @@ -68,7 +68,7 @@ int spk_punc_level, spk_reading_punc;
> char spk_str_caps_start[MAXVARLEN + 1] = "\0";
> char spk_str_caps_stop[MAXVARLEN + 1] = "\0";
> char spk_str_pause[MAXVARLEN + 1] = "\0";
> -bool spk_paused = 0;
> +bool spk_paused;
> const struct st_bits_data spk_punc_info[] = {
> {"none", "", 0},
> {"some", "/$%&@", SOME},
> @@ -1782,8 +1782,7 @@ static void speakup_con_update(struct vc
> /* Speakup output, discard */
> return;
> speakup_date(vc);
> - if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0])
> - {
> + if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0]) {
> synth_printf("%s", spk_str_pause);
> spk_paused = 1;

probably nice to change the assignments of
spk_paused to true&false too