2015-07-13 11:19:04

by Javier Martinez Canillas

Subject: [PATCH] serial: samsung: Remove redundant DEBUG_LL check

Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed
build issues when the driver was built as a module. One of those was
that printascii is only accessible when the driver is built-in.

But there is no need to check for defined(CONFIG_DEBUG_LL) since the
SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL.

Signed-off-by: Javier Martinez Canillas <[email protected]>

---

drivers/tty/serial/samsung.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index 67d0c213b1c7..8c963d6d9074 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -53,7 +53,6 @@
#include "samsung.h"

#if defined(CONFIG_SERIAL_SAMSUNG_DEBUG) && \
- defined(CONFIG_DEBUG_LL) && \
!defined(MODULE)

extern void printascii(const char *);
--
2.4.3

2015-07-14 01:56:39

by Krzysztof Kozlowski

Subject: Re: [PATCH] serial: samsung: Remove redundant DEBUG_LL check

On 13.07.2015 20:18, Javier Martinez Canillas wrote:
> Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed
> build issues when the driver was built as a module. One of those was
> that printascii is only accessible when the driver is built-in.
>
> But there is no need to check for defined(CONFIG_DEBUG_LL) since the
> SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL.
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
>
> ---
>
> drivers/tty/serial/samsung.c | 1 -
> 1 file changed, 1 deletion(-)

Although this redundancy is not harmful the patch seems fine, so:
Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2015-07-14 04:41:34

by Kukjin Kim

Subject: RE: [PATCH] serial: samsung: Remove redundant DEBUG_LL check

Krzysztof Kozlowski wrote:
>
> On 13.07.2015 20:18, Javier Martinez Canillas wrote:
> > Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed
> > build issues when the driver was built as a module. One of those was
> > that printascii is only accessible when the driver is built-in.
> >
> > But there is no need to check for defined(CONFIG_DEBUG_LL) since the
> > SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL.
> >
> > Signed-off-by: Javier Martinez Canillas <[email protected]>

Acked-by: Kukjin Kim <[email protected]>

Thanks,
Kukjin

> >
> > ---
> >
> > drivers/tty/serial/samsung.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Although this redundancy is not harmful the patch seems fine, so:
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
> Best regards,
> Krzysztof