2022-10-13 21:50:41

by Palmer Dabbelt

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: git://github -> https://github.com for cschaufler

Github deprecated the git:// links about a year ago, so let's move to
the https:// URLs instead.

Reported-by: Conor Dooley <[email protected]>
Link: https://github.blog/2021-09-01-improving-git-protocol-security-github/
Signed-off-by: Palmer Dabbelt <[email protected]>
---
I've split these up by github username so folks can take them
independently, as some of these repos have been renamed at github and
thus need more than just a sed to fix them.
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index daadd0de77a9..019cdb48e254 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18723,7 +18723,7 @@ M: Casey Schaufler <[email protected]>
L: [email protected]
S: Maintained
W: http://schaufler-ca.com
-T: git git://github.com/cschaufler/smack-next
+T: git https://github.com/cschaufler/smack-next
F: Documentation/admin-guide/LSM/Smack.rst
F: security/smack/

--
2.38.0


2022-10-13 22:34:08

by Paul Moore

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: git://github -> https://github.com for cschaufler

On Thu, Oct 13, 2022 at 5:49 PM Palmer Dabbelt <[email protected]> wrote:
>
> Github deprecated the git:// links about a year ago, so let's move to
> the https:// URLs instead.
>
> Reported-by: Conor Dooley <[email protected]>
> Link: https://github.blog/2021-09-01-improving-git-protocol-security-github/
> Signed-off-by: Palmer Dabbelt <[email protected]>
> ---
> I've split these up by github username so folks can take them
> independently, as some of these repos have been renamed at github and
> thus need more than just a sed to fix them.
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Casey is the one who needs to ACK this (and he has an email delay at
the moment), but the URL looks good to me.

Reviewed-by: Paul Moore <[email protected]>

> diff --git a/MAINTAINERS b/MAINTAINERS
> index daadd0de77a9..019cdb48e254 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18723,7 +18723,7 @@ M: Casey Schaufler <[email protected]>
> L: [email protected]
> S: Maintained
> W: http://schaufler-ca.com
> -T: git git://github.com/cschaufler/smack-next
> +T: git https://github.com/cschaufler/smack-next
> F: Documentation/admin-guide/LSM/Smack.rst
> F: security/smack/
>
> --
> 2.38.0

--
paul-moore.com

2022-10-14 04:27:07

by Palmer Dabbelt

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: git://github -> https://github.com for cschaufler

On Thu, 13 Oct 2022 14:54:00 PDT (-0700), [email protected] wrote:
> On Thu, Oct 13, 2022 at 5:49 PM Palmer Dabbelt <[email protected]> wrote:
>>
>> Github deprecated the git:// links about a year ago, so let's move to
>> the https:// URLs instead.
>>
>> Reported-by: Conor Dooley <[email protected]>
>> Link: https://github.blog/2021-09-01-improving-git-protocol-security-github/
>> Signed-off-by: Palmer Dabbelt <[email protected]>
>> ---
>> I've split these up by github username so folks can take them
>> independently, as some of these repos have been renamed at github and
>> thus need more than just a sed to fix them.
>> ---
>> MAINTAINERS | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Casey is the one who needs to ACK this (and he has an email delay at
> the moment), but the URL looks good to me.

No worries, I'm in no rush to merge this. Conor just pointed out the
RISC-V KVM URL having this issue so I scripted a patch for everyone.
Feel free to just take it through your tree if you want, otherwise I'll
keep it around locally and hopefully remember to send something once
it's Ack'd.

Just note that "MAINTAINERS: git://github -> https://github.com for" was
a scripting mistake, it should probably be "MAINTAINERS:
git://github.com -> https://github.com". If I have to re-spin this I'll
fix it, but if someone else is taking it then it's probably best to
fixup.

> Reviewed-by: Paul Moore <[email protected]>
>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index daadd0de77a9..019cdb48e254 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -18723,7 +18723,7 @@ M: Casey Schaufler <[email protected]>
>> L: [email protected]
>> S: Maintained
>> W: http://schaufler-ca.com
>> -T: git git://github.com/cschaufler/smack-next
>> +T: git https://github.com/cschaufler/smack-next
>> F: Documentation/admin-guide/LSM/Smack.rst
>> F: security/smack/
>>
>> --
>> 2.38.0

2022-10-20 16:30:33

by Casey Schaufler

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: git://github -> https://github.com for cschaufler

On 10/13/2022 2:46 PM, Palmer Dabbelt wrote:
> Github deprecated the git:// links about a year ago, so let's move to
> the https:// URLs instead.
>
> Reported-by: Conor Dooley <[email protected]>
> Link: https://github.blog/2021-09-01-improving-git-protocol-security-github/
> Signed-off-by: Palmer Dabbelt <[email protected]>

Reviewed-by: Casey Schaufler <[email protected]>

Do you want to apply this to your tree, or would you like me to
take it by the Smack tree? I'm fine either way.

> ---
> I've split these up by github username so folks can take them
> independently, as some of these repos have been renamed at github and
> thus need more than just a sed to fix them.
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index daadd0de77a9..019cdb48e254 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18723,7 +18723,7 @@ M: Casey Schaufler <[email protected]>
> L: [email protected]
> S: Maintained
> W: http://schaufler-ca.com
> -T: git git://github.com/cschaufler/smack-next
> +T: git https://github.com/cschaufler/smack-next
> F: Documentation/admin-guide/LSM/Smack.rst
> F: security/smack/
>