2019-10-25 19:30:38

by Juergen Gross

Subject: [PATCH] xen: issue deprecation warning for 32-bit pv guest

Support for the kernel as Xen 32-bit PV guest will soon be removed.
Issue a warning when booted as such.

Signed-off-by: Juergen Gross <[email protected]>
---
arch/x86/xen/enlighten_pv.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 58f79ab32358..5bfea374a160 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -117,6 +117,14 @@ static void __init xen_banner(void)
printk(KERN_INFO "Xen version: %d.%d%s%s\n",
version >> 16, version & 0xffff, extra.extraversion,
xen_feature(XENFEAT_mmu_pt_update_preserve_ad) ? " (preserve-AD)" : "");
+
+#ifdef CONFIG_X86_32
+ pr_warn("WARNING! WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!\n"
+ "Support for running as 32-bit PV-guest under Xen will soon be removed\n"
+ "from the Linux kernel!\n"
+ "Please use either a 64-bit kernel or switch to HVM or PVH mode!\n"
+ "WARNING! WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!\n");
+#endif
}

static void __init xen_pv_init_platform(void)
--
2.16.4

2019-10-25 20:21:47

by Boris Ostrovsky

Subject: Re: [PATCH] xen: issue deprecation warning for 32-bit pv guest

On 10/25/19 3:38 AM, Juergen Gross wrote:
> Support for the kernel as Xen 32-bit PV guest will soon be removed.
> Issue a warning when booted as such.
>
> Signed-off-by: Juergen Gross <[email protected]>

Reviewed-by: Boris Ostrovsky <[email protected]>

> ---
> arch/x86/xen/enlighten_pv.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
> index 58f79ab32358..5bfea374a160 100644
> --- a/arch/x86/xen/enlighten_pv.c
> +++ b/arch/x86/xen/enlighten_pv.c
> @@ -117,6 +117,14 @@ static void __init xen_banner(void)
> printk(KERN_INFO "Xen version: %d.%d%s%s\n",
> version >> 16, version & 0xffff, extra.extraversion,
> xen_feature(XENFEAT_mmu_pt_update_preserve_ad) ? " (preserve-AD)" : "");
> +
> +#ifdef CONFIG_X86_32
> + pr_warn("WARNING! WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!\n"
> + "Support for running as 32-bit PV-guest under Xen will soon be removed\n"
> + "from the Linux kernel!\n"
> + "Please use either a 64-bit kernel or switch to HVM or PVH mode!\n"
> + "WARNING! WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!\n");
> +#endif
> }
>
> static void __init xen_pv_init_platform(void)

2019-10-28 18:46:22

by H. Peter Anvin

Subject: Re: [PATCH] xen: issue deprecation warning for 32-bit pv guest

On October 25, 2019 12:38:58 AM PDT, Juergen Gross <[email protected]> wrote:
>Support for the kernel as Xen 32-bit PV guest will soon be removed.
>Issue a warning when booted as such.
>
>Signed-off-by: Juergen Gross <[email protected]>
>---
> arch/x86/xen/enlighten_pv.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
>index 58f79ab32358..5bfea374a160 100644
>--- a/arch/x86/xen/enlighten_pv.c
>+++ b/arch/x86/xen/enlighten_pv.c
>@@ -117,6 +117,14 @@ static void __init xen_banner(void)
> printk(KERN_INFO "Xen version: %d.%d%s%s\n",
> version >> 16, version & 0xffff, extra.extraversion,
> xen_feature(XENFEAT_mmu_pt_update_preserve_ad) ? "
>(preserve-AD)" : "");
>+
>+#ifdef CONFIG_X86_32
>+ pr_warn("WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!
>WARNING!\n"
>+ "Support for running as 32-bit PV-guest under Xen will soon be
>removed\n"
>+ "from the Linux kernel!\n"
>+ "Please use either a 64-bit kernel or switch to HVM or PVH mode!\n"
>+ "WARNING! WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!\n");
>+#endif
> }
>
> static void __init xen_pv_init_platform(void)

And there was much rejoicing.

Yaay.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.