2022-06-27 10:14:27

by Charles Keepax

[permalink] [raw]
Subject: [PATCH] ASoC: samsung: s3c24xx-i2s: Fix typo in DAIFMT handling

The conversion of the set_fmt callback to direct clock specification
included a small typo, correct the affected code.

Fixes: 91c49199e6d6 ("ASoC: samsung: Update to use set_fmt_new callback")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Charles Keepax <[email protected]>
---
sound/soc/samsung/s3c24xx-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c
index 4082ad7cbcc11..c1a314b86b155 100644
--- a/sound/soc/samsung/s3c24xx-i2s.c
+++ b/sound/soc/samsung/s3c24xx-i2s.c
@@ -170,7 +170,7 @@ static int s3c24xx_i2s_set_fmt(struct snd_soc_dai *cpu_dai,
pr_debug("hw_params r: IISMOD: %x \n", iismod);

switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
- case SND_SOC_DAIFMT_BC_CFC:
+ case SND_SOC_DAIFMT_BC_FC:
iismod |= S3C2410_IISMOD_SLAVE;
break;
case SND_SOC_DAIFMT_BP_FP:
--
2.30.2


2022-06-27 13:37:13

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] ASoC: samsung: s3c24xx-i2s: Fix typo in DAIFMT handling

On 27/06/2022 15:16, Charles Keepax wrote:
> On Mon, Jun 27, 2022 at 02:11:13PM +0200, Krzysztof Kozlowski wrote:
>> On 27/06/2022 13:45, Mark Brown wrote:
>>> On Mon, Jun 27, 2022 at 11:49:46AM +0200, Krzysztof Kozlowski wrote:
>>>> On 27/06/2022 11:43, Charles Keepax wrote:
>> My comment was not a requirement (procedural blocker) but a suggestion,
>> because maybe Charles was not aware that developer trees can be tested
>> for free.
>>
>
> Would be awesome if I could run things through the build bot
> before sending them up. Are there any docs anywhere on how to get
> a tree added to that?

For LKP:
https://github.com/intel/lkp-tests/pull/139

Sometimes intermediate work is also included in linux-next:
https://lore.kernel.org/linux-next/?q=s%3Ainclude+s%3Atree

Best regards,
Krzysztof

2022-06-27 21:29:01

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: samsung: s3c24xx-i2s: Fix typo in DAIFMT handling

On Mon, 27 Jun 2022 10:43:35 +0100, Charles Keepax wrote:
> The conversion of the set_fmt callback to direct clock specification
> included a small typo, correct the affected code.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: samsung: s3c24xx-i2s: Fix typo in DAIFMT handling
commit: ccb0bbe3e93efa1c794176200785737ba65b0131

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark