On 29/03/2022 18:30, Johan Jonker wrote:
> The rockchip,rk3328-cru.txt file was converted to YAML.
> A DT test of the rk3328 cru node gives notifications regarding
> the compatible string. Bring it in line with the binding by
> removing some unused fall back strings.
Are you sure these are unused? rockchip,cru maybe, but what about DTS
used out of tree? It's useful to mention that the compatible is not
documented (so if there are any out of tree users, it's their fault).
Removal of syscon is different case - why do you think it is unused? Did
you check it? It's not a fallback compatible.
>
> Signed-off-by: Johan Jonker <[email protected]>
> ---
> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index b822533dc..73418fd2f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -756,7 +756,7 @@
> };
>
> cru: clock-controller@ff440000 {
> - compatible = "rockchip,rk3328-cru", "rockchip,cru", "syscon";
> + compatible = "rockchip,rk3328-cru";
> reg = <0x0 0xff440000 0x0 0x1000>;
> rockchip,grf = <&grf>;
> #clock-cells = <1>;
Best regards,
Krzysztof
On 3/29/22 19:23, Krzysztof Kozlowski wrote:
> On 29/03/2022 18:30, Johan Jonker wrote:
>> The rockchip,rk3328-cru.txt file was converted to YAML.
>> A DT test of the rk3328 cru node gives notifications regarding
>> the compatible string. Bring it in line with the binding by
>> removing some unused fall back strings.
>
> Are you sure these are unused? rockchip,cru maybe, but what about DTS
> used out of tree? It's useful to mention that the compatible is not
> documented (so if there are any out of tree users, it's their fault).
>
> Removal of syscon is different case - why do you think it is unused? Did
> you check it? It's not a fallback compatible.
Hi,
If someone knows why that was added to the Rockchip tree? Let us
know.(Elaine ??)
Other well know locations don't seem to use it.
Please advise.
Johan
===
https://github.com/torvalds/linux/search?q=rockchip%2Ccru&type=code
https://source.denx.de/search?search=rockchip%2Ccru&group_id=325&project_id=540&scope=&search_code=true&snippets=false&repository_ref=master&nav_source=navbar
https://github.com/rockchip-linux/kernel/search?q=rockchip%2Ccru&type=code
>
>>
>> Signed-off-by: Johan Jonker <[email protected]>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> index b822533dc..73418fd2f 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> @@ -756,7 +756,7 @@
>> };
>>
>> cru: clock-controller@ff440000 {
>> - compatible = "rockchip,rk3328-cru", "rockchip,cru", "syscon";
>> + compatible = "rockchip,rk3328-cru";
>> reg = <0x0 0xff440000 0x0 0x1000>;
>> rockchip,grf = <&grf>;
>> #clock-cells = <1>;
>
>
> Best regards,
> Krzysztof