Am 28.11.2017 um 20:34 schrieb Joe Perches:
> Make the object a bit smaller by using a simple string instead
> of a format string and array of char *.
>
> $ size drivers/gpu/drm/ttm/ttm_page_alloc_dma.o*
> text data bss dec hex filename
> 8820 216 4136 13172 3374 drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.defconfig.new
> 8910 216 4136 13262 33ce drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.defconfig.old
> 25383 5044 4384 34811 87fb drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.allyesconfig.new
> 25797 5428 4384 35609 8b19 drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.allyesconfig.old
>
> Miscellanea:
>
> o The h array had more entries than were emitted, all are now removed
>
> Signed-off-by: Joe Perches <[email protected]>
Reviewed-by: Christian König <[email protected]>
> ---
> drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
> index 6b2627fe9bc1..bda00b2ab51c 100644
> --- a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
> +++ b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
> @@ -1244,15 +1244,12 @@ int ttm_dma_page_alloc_debugfs(struct seq_file *m, void *data)
> {
> struct device_pools *p;
> struct dma_pool *pool = NULL;
> - char *h[] = {"pool", "refills", "pages freed", "inuse", "available",
> - "name", "virt", "busaddr"};
>
> if (!_manager) {
> seq_printf(m, "No pool allocator running.\n");
> return 0;
> }
> - seq_printf(m, "%13s %12s %13s %8s %8s %8s\n",
> - h[0], h[1], h[2], h[3], h[4], h[5]);
> + seq_printf(m, " pool refills pages freed inuse available name\n");
> mutex_lock(&_manager->lock);
> list_for_each_entry(p, &_manager->pools, pools) {
> struct device *dev = p->dev;
From 1585339733630602047@xxx Tue Nov 28 19:36:26 +0000 2017
X-GM-THRID: 1585339733630602047
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread