2012-11-19 05:02:10

by Sachin Kamat

Subject: [PATCH 1/1] pinctrl: Samsung: Do not initialise statics to 0

Static variables are initialised to 0 by GCC.
Fixes the following checkpatch error:
ERROR: do not initialise statics to 0 or NULL
FILE: pinctrl/pinctrl-samsung.c:50:
static unsigned int pin_base = 0;

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/pinctrl/pinctrl-samsung.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c
index 81c9896..36f8875 100644
--- a/drivers/pinctrl/pinctrl-samsung.c
+++ b/drivers/pinctrl/pinctrl-samsung.c
@@ -47,7 +47,7 @@ struct pin_config {
{ "samsung,pin-pud-pdn", PINCFG_TYPE_PUD_PDN },
};

-static unsigned int pin_base = 0;
+static unsigned int pin_base;

static inline struct samsung_pin_bank *gc_to_pin_bank(struct gpio_chip *gc)
{
--
1.7.4.1

2012-11-20 11:49:31

by Kukjin Kim

Subject: RE: [PATCH 1/1] pinctrl: Samsung: Do not initialise statics to 0

Sachin Kamat wrote:
>
> Static variables are initialised to 0 by GCC.
> Fixes the following checkpatch error:
> ERROR: do not initialise statics to 0 or NULL
> FILE: pinctrl/pinctrl-samsung.c:50:
> static unsigned int pin_base = 0;
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/pinctrl/pinctrl-samsung.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-
> samsung.c
> index 81c9896..36f8875 100644
> --- a/drivers/pinctrl/pinctrl-samsung.c
> +++ b/drivers/pinctrl/pinctrl-samsung.c
> @@ -47,7 +47,7 @@ struct pin_config {
> { "samsung,pin-pud-pdn", PINCFG_TYPE_PUD_PDN },
> };
>
> -static unsigned int pin_base = 0;
> +static unsigned int pin_base;
>
> static inline struct samsung_pin_bank *gc_to_pin_bank(struct gpio_chip
> *gc)
> {
> --
> 1.7.4.1

Looks OK to me.

Linus, can I pick this up in my tree?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

2012-11-23 07:36:28

by Linus Walleij

Subject: Re: [PATCH 1/1] pinctrl: Samsung: Do not initialise statics to 0

On Tue, Nov 20, 2012 at 12:49 PM, Kukjin Kim <[email protected]> wrote:
> Sachin Kamat wrote:
>>
>> Static variables are initialised to 0 by GCC.
>> Fixes the following checkpatch error:
>> ERROR: do not initialise statics to 0 or NULL
>> FILE: pinctrl/pinctrl-samsung.c:50:
>> static unsigned int pin_base = 0;
>>
>> Signed-off-by: Sachin Kamat <[email protected]>
> (...)
>
> Looks OK to me.
>
> Linus, can I pick this up in my tree?

Yes, go ahead:
Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij