2018-01-13 09:34:47

by SF Markus Elfring

Subject: [PATCH] memory-EMIF: Use seq_putc() in emif_regdump_show()

From: Markus Elfring <[email protected]>
Date: Sat, 13 Jan 2018 10:24:03 +0100

A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/memory/emif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 04644e7b42b1..2f214440008c 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -127,7 +127,7 @@ static int emif_regdump_show(struct seq_file *s, void *unused)

for (i = 0; i < EMIF_MAX_NUM_FREQUENCIES && regs_cache[i]; i++) {
do_emif_regdump_show(s, emif, regs_cache[i]);
- seq_printf(s, "\n");
+ seq_putc(s, '\n');
}

return 0;
--
2.15.1

2018-01-17 18:05:25

by Santosh Shilimkar

Subject: Re: [PATCH] memory-EMIF: Use seq_putc() in emif_regdump_show()

On 1/13/2018 1:34 AM, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Sat, 13 Jan 2018 10:24:03 +0100
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
Looks fine. Will pick it up for next merge window.

Regards,
Santosh