On Tue, Apr 12, 2022 at 11:21:26AM +0800, Tiezhu Yang wrote:
> Remove the following section entries of IOMAP FILESYSTEM LIBRARY:
>
> M: [email protected]
> M: [email protected]
>
> Remove the following section entry of XFS FILESYSTEM:
>
> M: [email protected]
>
> Signed-off-by: Tiezhu Yang <[email protected]>
WTF?
▄▄ ▄ ▄▄ ▄ ▄
█▀▄ █ ██ █ ▄▀
█ █▄ █ █ █ █▄█
█ █ █ █▄▄█ █ █▄
█ ██ █ █ █ ▀▄
--D
> ---
> MAINTAINERS | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 61d9f11..726608f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10238,8 +10238,6 @@ F: drivers/net/ethernet/sgi/ioc3-eth.c
> IOMAP FILESYSTEM LIBRARY
> M: Christoph Hellwig <[email protected]>
> M: Darrick J. Wong <[email protected]>
> -M: [email protected]
> -M: [email protected]
> L: [email protected]
> L: [email protected]
> S: Supported
> @@ -21596,7 +21594,6 @@ F: drivers/xen/*swiotlb*
> XFS FILESYSTEM
> C: irc://irc.oftc.net/xfs
> M: Darrick J. Wong <[email protected]>
> -M: [email protected]
> L: [email protected]
> S: Supported
> W: http://xfs.org/
> --
> 2.1.0
>
On Mon, Apr 11, 2022 at 08:39:17PM -0700, Darrick J. Wong wrote:
> On Tue, Apr 12, 2022 at 11:21:26AM +0800, Tiezhu Yang wrote:
> > Remove the following section entries of IOMAP FILESYSTEM LIBRARY:
> >
> > M: [email protected]
> > M: [email protected]
> >
> > Remove the following section entry of XFS FILESYSTEM:
> >
> > M: [email protected]
> >
> > Signed-off-by: Tiezhu Yang <[email protected]>
>
> WTF?
>
> ▄▄ ▄ ▄▄ ▄ ▄
> █▀▄ █ ██ █ ▄▀
> █ █▄ █ █ █ █▄█
> █ █ █ █▄▄█ █ █▄
> █ ██ █ █ █ ▀▄
*OH*, I see, you're getting rid of the M(ail): entry, probably because
it's redundant with L(ist): or something?? Still... why does it matter?
Seriously, changelogs need to say /why/ they're changing something, not
simply restate what's already in the diff.
--D
>
> --D
>
> > ---
> > MAINTAINERS | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 61d9f11..726608f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -10238,8 +10238,6 @@ F: drivers/net/ethernet/sgi/ioc3-eth.c
> > IOMAP FILESYSTEM LIBRARY
> > M: Christoph Hellwig <[email protected]>
> > M: Darrick J. Wong <[email protected]>
> > -M: [email protected]
> > -M: [email protected]
> > L: [email protected]
> > L: [email protected]
> > S: Supported
> > @@ -21596,7 +21594,6 @@ F: drivers/xen/*swiotlb*
> > XFS FILESYSTEM
> > C: irc://irc.oftc.net/xfs
> > M: Darrick J. Wong <[email protected]>
> > -M: [email protected]
> > L: [email protected]
> > S: Supported
> > W: http://xfs.org/
> > --
> > 2.1.0
> >
On 04/12/2022 11:50 AM, Darrick J. Wong wrote:
> On Mon, Apr 11, 2022 at 08:39:17PM -0700, Darrick J. Wong wrote:
>> On Tue, Apr 12, 2022 at 11:21:26AM +0800, Tiezhu Yang wrote:
>>> Remove the following section entries of IOMAP FILESYSTEM LIBRARY:
>>>
>>> M: [email protected]
>>> M: [email protected]
>>>
>>> Remove the following section entry of XFS FILESYSTEM:
>>>
>>> M: [email protected]
>>>
>>> Signed-off-by: Tiezhu Yang <[email protected]>
>>
>> WTF?
>>
>> ▄▄ ▄ ▄▄ ▄ ▄
>> █▀▄ █ ██ █ ▄▀
>> █ █▄ █ █ █ █▄█
>> █ █ █ █▄▄█ █ █▄
>> █ ██ █ █ █ ▀▄
>
> *OH*, I see, you're getting rid of the M(ail): entry, probably because
> it's redundant with L(ist): or something?? Still... why does it matter?
Yes, the section entries are redundant. Sorry for the unclear description.
The intention of this patch is to clean up the redundant section entries.
>
> Seriously, changelogs need to say /why/ they're changing something, not
> simply restate what's already in the diff.
OK, thank you. Should I send a v2 patch to update the commit message
or just ignore this patch?
Thanks,
Tiezhu
On Tue, Apr 12, 2022 at 12:55:39PM +0800, Tiezhu Yang wrote:
>
>
> On 04/12/2022 11:50 AM, Darrick J. Wong wrote:
> > On Mon, Apr 11, 2022 at 08:39:17PM -0700, Darrick J. Wong wrote:
> > > On Tue, Apr 12, 2022 at 11:21:26AM +0800, Tiezhu Yang wrote:
> > > > Remove the following section entries of IOMAP FILESYSTEM LIBRARY:
> > > >
> > > > M: [email protected]
> > > > M: [email protected]
> > > >
> > > > Remove the following section entry of XFS FILESYSTEM:
> > > >
> > > > M: [email protected]
> > > >
> > > > Signed-off-by: Tiezhu Yang <[email protected]>
> > >
> > > WTF?
> > >
> > > ▄▄ ▄ ▄▄ ▄ ▄
> > > █▀▄ █ ██ █ ▄▀
> > > █ █▄ █ █ █ █▄█
> > > █ █ █ █▄▄█ █ █▄
> > > █ ██ █ █ █ ▀▄
> >
> > *OH*, I see, you're getting rid of the M(ail): entry, probably because
> > it's redundant with L(ist): or something?? Still... why does it matter?
>
> Yes, the section entries are redundant. Sorry for the unclear description.
>
> The intention of this patch is to clean up the redundant section entries.
>
> >
> > Seriously, changelogs need to say /why/ they're changing something, not
> > simply restate what's already in the diff.
>
> OK, thank you. Should I send a v2 patch to update the commit message
> or just ignore this patch?
Yes, please send a v2 patch with an improved commit message. NAK
withdrawn.
--D
> Thanks,
> Tiezhu
>