2012-11-20 22:49:33

by Doug Anderson

Subject: [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports

From: Olof Johansson <[email protected]>

UART3 is used for debugging on exynos5250-snow.

[dianders: cleaned commit message.]

Signed-off-by: Olof Johansson <[email protected]>
Signed-off-by: Doug Anderson <[email protected]>

---
arch/arm/Kconfig.debug | 11 +++++++++++
arch/arm/plat-samsung/Kconfig | 1 +
2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 33a8930..35ba7dc 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -355,6 +355,17 @@ choice
The uncompressor code port configuration is now handled
by CONFIG_S3C_LOWLEVEL_UART_PORT.

+ config DEBUG_S3C_UART3
+ depends on PLAT_SAMSUNG
+ bool "Use S3C UART 3 for low-level debug"
+ help
+ Say Y here if you want the debug print routines to direct
+ their output to UART 3. The port must have been initialised
+ by the boot-loader before use.
+
+ The uncompressor code port configuration is now handled
+ by CONFIG_S3C_LOWLEVEL_UART_PORT.
+
config DEBUG_SOCFPGA_UART
depends on ARCH_SOCFPGA
bool "Use SOCFPGA UART for low-level debug"
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index 59401e1..d342ed0 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -502,5 +502,6 @@ config DEBUG_S3C_UART
default "0" if DEBUG_S3C_UART0
default "1" if DEBUG_S3C_UART1
default "2" if DEBUG_S3C_UART2
+ default "3" if DEBUG_S3C_UART3

endif
--
1.7.7.3

2012-11-21 07:30:05

by Olof Johansson

Subject: Re: [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports

On Tue, Nov 20, 2012 at 02:48:58PM -0800, Doug Anderson wrote:
> From: Olof Johansson <[email protected]>
>
> UART3 is used for debugging on exynos5250-snow.
>
> [dianders: cleaned commit message.]
>
> Signed-off-by: Olof Johansson <[email protected]>
> Signed-off-by: Doug Anderson <[email protected]>

>
> ---
> arch/arm/Kconfig.debug | 11 +++++++++++
> arch/arm/plat-samsung/Kconfig | 1 +
> 2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 33a8930..35ba7dc 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -355,6 +355,17 @@ choice
> The uncompressor code port configuration is now handled
> by CONFIG_S3C_LOWLEVEL_UART_PORT.
>
> + config DEBUG_S3C_UART3
> + depends on PLAT_SAMSUNG


Sorry, the reason I hadn't re-posted this is that Kukjin had proposed
to protect users of <= 3 UART platforms to select it. An added "Depends
on ARCH_EXYNOS4 || ARCH_EXYNOS5" should cover that. Can you add and
repost, please?


-Olof

2012-11-21 09:49:44

by Kukjin Kim

Subject: RE: [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports

Olof Johansson wrote:
>
> On Tue, Nov 20, 2012 at 02:48:58PM -0800, Doug Anderson wrote:
> > From: Olof Johansson <[email protected]>
> >
> > UART3 is used for debugging on exynos5250-snow.
> >
> > [dianders: cleaned commit message.]
> >
> > Signed-off-by: Olof Johansson <[email protected]>
> > Signed-off-by: Doug Anderson <[email protected]>
>
> >
> > ---
> > arch/arm/Kconfig.debug | 11 +++++++++++
> > arch/arm/plat-samsung/Kconfig | 1 +
> > 2 files changed, 12 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index 33a8930..35ba7dc 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -355,6 +355,17 @@ choice
> > The uncompressor code port configuration is now handled
> > by CONFIG_S3C_LOWLEVEL_UART_PORT.
> >
> > + config DEBUG_S3C_UART3
> > + depends on PLAT_SAMSUNG
>
>
> Sorry, the reason I hadn't re-posted this is that Kukjin had proposed
> to protect users of <= 3 UART platforms to select it. An added "Depends
> on ARCH_EXYNOS4 || ARCH_EXYNOS5" should cover that. Can you add and
> repost, please?
>
Yes, please :-)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

2012-11-21 16:58:35

by Doug Anderson

Subject: Re: [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports

On Tue, Nov 20, 2012 at 11:29 PM, Olof Johansson <[email protected]> wrote:
>
> On Tue, Nov 20, 2012 at 02:48:58PM -0800, Doug Anderson wrote:
> > From: Olof Johansson <[email protected]>
> >
> > UART3 is used for debugging on exynos5250-snow.
> >
> > [dianders: cleaned commit message.]
> >
> > Signed-off-by: Olof Johansson <[email protected]>
> > Signed-off-by: Doug Anderson <[email protected]>
>
> >
> > ---
> > arch/arm/Kconfig.debug | 11 +++++++++++
> > arch/arm/plat-samsung/Kconfig | 1 +
> > 2 files changed, 12 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index 33a8930..35ba7dc 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -355,6 +355,17 @@ choice
> > The uncompressor code port configuration is now handled
> > by CONFIG_S3C_LOWLEVEL_UART_PORT.
> >
> > + config DEBUG_S3C_UART3
> > + depends on PLAT_SAMSUNG
>
>
> Sorry, the reason I hadn't re-posted this is that Kukjin had proposed
> to protect users of <= 3 UART platforms to select it. An added "Depends
> on ARCH_EXYNOS4 || ARCH_EXYNOS5" should cover that. Can you add and
> repost, please?

Doh! I hadn't even noticed that you'd already posted this--I got mine
from the Chrome OS tree directly. Sorry about that...

I've added an && for ARCH_EXYNOS which seems reasonable. I left
PLAT_SAMSUNG as a depend though technically ARCH_EXYNOS does select
PLAT_SAMSUNG through a convoluted series of other config options.

-Doug

2012-11-21 16:58:39

by Doug Anderson

Subject: [PATCH v2] ARM: exynos: add UART3 to DEBUG_LL ports

From: Olof Johansson <[email protected]>

Add support for using UART3 for DEBUG_LL on exynos.

[dianders: added depend on ARCH_EXYNOS.]

Signed-off-by: Olof Johansson <[email protected]>
Signed-off-by: Doug Anderson <[email protected]>

---
Changes in v2:
- Matched Olof's commit message.
- Added ARCH_EXYNOS to depend list.

arch/arm/Kconfig.debug | 11 +++++++++++
arch/arm/plat-samsung/Kconfig | 1 +
2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 33a8930..f54f170 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -355,6 +355,17 @@ choice
The uncompressor code port configuration is now handled
by CONFIG_S3C_LOWLEVEL_UART_PORT.

+ config DEBUG_S3C_UART3
+ depends on PLAT_SAMSUNG && ARCH_EXYNOS
+ bool "Use S3C UART 3 for low-level debug"
+ help
+ Say Y here if you want the debug print routines to direct
+ their output to UART 3. The port must have been initialised
+ by the boot-loader before use.
+
+ The uncompressor code port configuration is now handled
+ by CONFIG_S3C_LOWLEVEL_UART_PORT.
+
config DEBUG_SOCFPGA_UART
depends on ARCH_SOCFPGA
bool "Use SOCFPGA UART for low-level debug"
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index 59401e1..d342ed0 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -502,5 +502,6 @@ config DEBUG_S3C_UART
default "0" if DEBUG_S3C_UART0
default "1" if DEBUG_S3C_UART1
default "2" if DEBUG_S3C_UART2
+ default "3" if DEBUG_S3C_UART3

endif
--
1.7.7.3

2012-11-22 19:00:46

by Kukjin Kim

Subject: RE: [PATCH v2] ARM: exynos: add UART3 to DEBUG_LL ports

Doug Anderson wrote:
>
> From: Olof Johansson <[email protected]>
>
> Add support for using UART3 for DEBUG_LL on exynos.
>
> [dianders: added depend on ARCH_EXYNOS.]
>
> Signed-off-by: Olof Johansson <[email protected]>
> Signed-off-by: Doug Anderson <[email protected]>
>
> ---
> Changes in v2:
> - Matched Olof's commit message.
> - Added ARCH_EXYNOS to depend list.
>
> arch/arm/Kconfig.debug | 11 +++++++++++
> arch/arm/plat-samsung/Kconfig | 1 +
> 2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 33a8930..f54f170 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -355,6 +355,17 @@ choice
> The uncompressor code port configuration is now handled
> by CONFIG_S3C_LOWLEVEL_UART_PORT.
>
> + config DEBUG_S3C_UART3
> + depends on PLAT_SAMSUNG && ARCH_EXYNOS
> + bool "Use S3C UART 3 for low-level debug"
> + help
> + Say Y here if you want the debug print routines to direct
> + their output to UART 3. The port must have been
initialised
> + by the boot-loader before use.
> +
> + The uncompressor code port configuration is now handled
> + by CONFIG_S3C_LOWLEVEL_UART_PORT.
> +
> config DEBUG_SOCFPGA_UART
> depends on ARCH_SOCFPGA
> bool "Use SOCFPGA UART for low-level debug"
> diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> index 59401e1..d342ed0 100644
> --- a/arch/arm/plat-samsung/Kconfig
> +++ b/arch/arm/plat-samsung/Kconfig
> @@ -502,5 +502,6 @@ config DEBUG_S3C_UART
> default "0" if DEBUG_S3C_UART0
> default "1" if DEBUG_S3C_UART1
> default "2" if DEBUG_S3C_UART2
> + default "3" if DEBUG_S3C_UART3
>
> endif
> --
> 1.7.7.3

Applied, thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.