2023-10-24 03:36:31

by CK Hu (胡俊光)

Subject: Re: [PATCH v2 04/11] drm/mediatek: Add secure identify flag and funcution to mtk_drm_plane

Hi, Jason:

On Mon, 2023-10-23 at 12:45 +0800, Jason-JH.Lin wrote:
> Add is_sec flag to identify current mtk_drm_plane is secure.
> Add mtk_plane_is_sec_fb() to check current drm_framebuffer is secure.
>
> Signed-off-by: Jason-JH.Lin <[email protected]>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_plane.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.h
> b/drivers/gpu/drm/mediatek/mtk_drm_plane.h
> index 99aff7da0831..fe60e20a6e1c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.h
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.h
> @@ -33,6 +33,7 @@ struct mtk_plane_pending_state {
> bool async_dirty;
> bool async_config;
> enum drm_color_encoding color_encoding;
> + bool is_sec;

Where do you set this flag?

Regards,
CK

> };
>
> struct mtk_plane_state {
> @@ -46,6 +47,7 @@ to_mtk_plane_state(struct drm_plane_state *state)
> return container_of(state, struct mtk_plane_state, base);
> }
>
> +bool mtk_plane_fb_is_secure(struct drm_framebuffer *fb);
> int mtk_plane_init(struct drm_device *dev, struct drm_plane *plane,
> unsigned long possible_crtcs, enum drm_plane_type
> type,
> unsigned int supported_rotations, const u32
> *formats,

2023-10-25 06:39:57

by Jason-JH.Lin

Subject: Re: [PATCH v2 04/11] drm/mediatek: Add secure identify flag and funcution to mtk_drm_plane

Hi CK,

On Tue, 2023-10-24 at 03:35 +0000, CK Hu (胡俊光) wrote:
> Hi, Jason:
>
> On Mon, 2023-10-23 at 12:45 +0800, Jason-JH.Lin wrote:
> > Add is_sec flag to identify current mtk_drm_plane is secure.
> > Add mtk_plane_is_sec_fb() to check current drm_framebuffer is
> > secure.
> >
> > Signed-off-by: Jason-JH.Lin <[email protected]>
> > ---
> > drivers/gpu/drm/mediatek/mtk_drm_plane.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.h
> > b/drivers/gpu/drm/mediatek/mtk_drm_plane.h
> > index 99aff7da0831..fe60e20a6e1c 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.h
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.h
> > @@ -33,6 +33,7 @@ struct mtk_plane_pending_state {
> > bool async_dirty;
> > bool async_config;
> > enum drm_color_encoding color_encoding;
> > + bool is_sec;
>
> Where do you set this flag?
>

I think I lost that part of code in this patch...
I'll add them in the next version.

Regards,
Jason-JH.Lin

> Regards,
> CK
>