2022-07-17 23:54:18

by Adam Borowski

[permalink] [raw]
Subject: [PATCH] certs: make system keyring depend on x509 parser

This code requires x509_load_certificate_list() to be built-in.

Fixes: 60050ffe3d770dd1df5b641aa48f49d07a54bd84
Signed-off-by: Adam Borowski <[email protected]>
---
Otherwise, we get a build failure.

certs/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/certs/Kconfig b/certs/Kconfig
index 476755703cf8..bf9b511573d7 100644
--- a/certs/Kconfig
+++ b/certs/Kconfig
@@ -43,6 +43,7 @@ config SYSTEM_TRUSTED_KEYRING
bool "Provide system-wide ring of trusted keys"
depends on KEYS
depends on ASYMMETRIC_KEY_TYPE
+ depends on X509_CERTIFICATE_PARSER
help
Provide a system keyring to which trusted keys can be added. Keys in
the keyring are considered to be trusted. Keys may be added at will
--
2.36.1


Subject: Re: [PATCH] certs: make system keyring depend on x509 parser

Hi, this is your Linux kernel regression tracker.

Thx for looking into this.

On 18.07.22 01:11, Adam Borowski wrote:
> This code requires x509_load_certificate_list() to be built-in.
>
> Fixes: 60050ffe3d770dd1df5b641aa48f49d07a54bd84

Just BTW: per docs.kernel.org/process/submitting-patches.html this
should be

Fixes: 60050ffe3d77 ("certs: Move load_certificate_list() to be with the
asymmetric keys code")

But I write for a different reason: Could you also please add "Link:"
and "Reported-by:" tags for earlier reports about this issue please:

Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/all/[email protected]/
Reported-by: Steven Rostedt <[email protected]>
Link:
https://lore.kernel.org/all/[email protected]/

tia

> […]

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

P.P.S.: Let me tell regzbot to monitor this thread:

#regzbot ^backmonitor:
https://lore.kernel.org/all/[email protected]/

2022-07-18 14:33:02

by Adam Borowski

[permalink] [raw]
Subject: [PATCH] certs: make system keyring depend on x509 parser

This code requires x509_load_certificate_list() to be built-in.

Fixes: 60050ffe3d77 ("certs: Move load_certificate_list() to be with the
asymmetric keys code")
Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/all/[email protected]/
Reported-by: Steven Rostedt <[email protected]>
Link: https://lore.kernel.org/all/[email protected]/
Signed-off-by: Adam Borowski <[email protected]>
---
certs/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/certs/Kconfig b/certs/Kconfig
index 476755703cf8..bf9b511573d7 100644
--- a/certs/Kconfig
+++ b/certs/Kconfig
@@ -43,6 +43,7 @@ config SYSTEM_TRUSTED_KEYRING
bool "Provide system-wide ring of trusted keys"
depends on KEYS
depends on ASYMMETRIC_KEY_TYPE
+ depends on X509_CERTIFICATE_PARSER
help
Provide a system keyring to which trusted keys can be added. Keys in
the keyring are considered to be trusted. Keys may be added at will
--
2.36.1