2003-08-30 13:15:48

by Matthew Wilcox

[permalink] [raw]
Subject: Re: [parisc-linux] Security Hole in binfmt_som.c ?

On Sat, Aug 30, 2003 at 02:42:37PM +0200, Ruediger Scholz wrote:
> binfmt_som.c:216:2: #error "Fix security hole before enabling me"
> What's this message about?

I don't know. I wish someone would tell me. You'd think they'd have the
decency to contact the person listed as the author at the top of the file.

--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk


2003-08-30 13:50:51

by Alan

[permalink] [raw]
Subject: Re: [parisc-linux] Security Hole in binfmt_som.c ?

On Sad, 2003-08-30 at 14:15, Matthew Wilcox wrote:
> On Sat, Aug 30, 2003 at 02:42:37PM +0200, Ruediger Scholz wrote:
> > binfmt_som.c:216:2: #error "Fix security hole before enabling me"
> > What's this message about?
>
> I don't know. I wish someone would tell me. You'd think they'd have the
> decency to contact the person listed as the author at the top of the file.

Actually explanations were posted in the previous discussion on this on
parisc-list.

Someone has to do the equivalent of the 2.4.22 binfmt_elf changes if
neccessary so that another thread can't change the file handles or
steal the exec fd being passed to the loader.

2003-08-30 13:59:35

by Matthew Wilcox

[permalink] [raw]
Subject: Re: [parisc-linux] Security Hole in binfmt_som.c ?

On Sat, Aug 30, 2003 at 02:49:50PM +0100, Alan Cox wrote:
> On Sad, 2003-08-30 at 14:15, Matthew Wilcox wrote:
> > On Sat, Aug 30, 2003 at 02:42:37PM +0200, Ruediger Scholz wrote:
> > > binfmt_som.c:216:2: #error "Fix security hole before enabling me"
> > > What's this message about?
> >
> > I don't know. I wish someone would tell me. You'd think they'd have the
> > decency to contact the person listed as the author at the top of the file.
>
> Actually explanations were posted in the previous discussion on this on
> parisc-list.

Um, I can't find it, and neither can Google:
http://www.google.com/search?q=binfmt_som+security&as_q=%5Bparisc-linux&btnG=Google+Search&as_sitesearch=lists.parisc-linux.org

> Someone has to do the equivalent of the 2.4.22 binfmt_elf changes if
> neccessary so that another thread can't change the file handles or
> steal the exec fd being passed to the loader.

Hm, ok, I'll take a look later this weekend if no-one gets to it first.

--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

2003-08-30 23:34:04

by Alan

[permalink] [raw]
Subject: Re: [parisc-linux] Security Hole in binfmt_som.c ?

On Sad, 2003-08-30 at 14:59, Matthew Wilcox wrote:
> Um, I can't find it, and neither can Google:
> http://www.google.com/search?q=binfmt_som+security&as_q=%5Bparisc-linux&btnG=Google+Search&as_sitesearch=lists.parisc-linux.org

Humm I thought it was on this list. Maybe lkml then

Whatever the basic problem is we have kernel loaders and
user threads sharing a file table unsafely

2003-09-01 08:00:29

by Joel Soete

[permalink] [raw]
Subject: Re: [parisc-linux] Security Hole in binfmt_som.c ?

Alan Cox wrote:

>On Sad, 2003-08-30 at 14:15, Matthew Wilcox wrote:
>
>
>>On Sat, Aug 30, 2003 at 02:42:37PM +0200, Ruediger Scholz wrote:
>>
>>
>>>binfmt_som.c:216:2: #error "Fix security hole before enabling me"
>>>What's this message about?
>>>
>>>
>>I don't know. I wish someone would tell me. You'd think they'd have the
>>decency to contact the person listed as the author at the top of the file.
>>
>>
>
>Actually explanations were posted in the previous discussion on this on
>parisc-list.
>
>Someone has to do the equivalent of the 2.4.22 binfmt_elf changes if
>neccessary so that another thread can't change the file handles or
>steal the exec fd being passed to the loader.
>
>
>
Yes Alan, it was:
<http://lists.parisc-linux.org/pipermail/parisc-linux/2003-July/020386.html>

Sorry Willy I trusted that you read it (My bad next time I will advise
you directly)

Joel