2004-06-09 12:43:49

by Jörn Engel

[permalink] [raw]
Subject: [STACK] >4k call path in hp/compaq fibre channel driver

Chase, I guess this code won't live long with 4k stacks. Can you
please fix CpqTsProcessIMQEntry() and PeekIMQEntry()?

Linus, Andrew, how about marking CONFIG_SCSI_CPQFCTS as broken for the
time being?

stackframes for call path too long (4144):
size function
0
____FAKE.Name.Chip.stat.Regi.LILP.Opti.high.lowe->ProcessIMQEntry
2076 CpqTsProcessIMQEntry
2052 PeekIMQEntry
16 CpqTsGetSFQEntry
0 __constant_memcpy
0 __builtin_memcpy

J?rn

--
The grand essentials of happiness are: something to do, something to
love, and something to hope for.
-- Allan K. Chalmers


2004-06-09 12:51:12

by Arjan van de Ven

[permalink] [raw]
Subject: Re: [STACK] >4k call path in hp/compaq fibre channel driver

On Wed, 2004-06-09 at 14:43, Jörn Engel wrote:
> Chase, I guess this code won't live long with 4k stacks. Can you
> please fix CpqTsProcessIMQEntry() and PeekIMQEntry()?
>
> Linus, Andrew, how about marking CONFIG_SCSI_CPQFCTS as broken for the
> time being?

isn't it already? I thought it never got adjusted to the 2.6 scsi layer
already (or the 2.4 one for that matter)


Attachments:
signature.asc (189.00 B)
This is a digitally signed message part

2004-06-09 12:59:30

by Jörn Engel

[permalink] [raw]
Subject: Re: [STACK] >4k call path in hp/compaq fibre channel driver

On Wed, 9 June 2004 14:50:54 +0200, Arjan van de Ven wrote:
> On Wed, 2004-06-09 at 14:43, J?rn Engel wrote:
> > Chase, I guess this code won't live long with 4k stacks. Can you
> > please fix CpqTsProcessIMQEntry() and PeekIMQEntry()?
> >
> > Linus, Andrew, how about marking CONFIG_SCSI_CPQFCTS as broken for the
> > time being?
>
> isn't it already? I thought it never got adjusted to the 2.6 scsi layer
> already (or the 2.4 one for that matter)

Doesn't look like it.

But that's a good point. I could use allnonbrokenconfig for stack
tests the next time.

config SCSI_CPQFCTS
tristate "Compaq Fibre Channel 64-bit/66Mhz HBA support"
depends on PCI && SCSI
help
Say Y here to compile in support for the Compaq StorageWorks Fibre
Channel 64-bit/66Mhz Host Bus Adapter.

J?rn

--
Happiness isn't having what you want, it's wanting what you have.
-- unknown