2020-03-24 00:24:30

by H. Peter Anvin

[permalink] [raw]
Subject: Re: [PATCH v2 9/9] x86: replace arch macros from compiler with CONFIG_X86_{32,64}

On 2020-03-23 17:13, Masahiro Yamada wrote:
> If the intention is to check i386/x86_64 excluding UML,
> checking CONFIG_X86_{32,64} is simpler.
>
> The reason for checking __i386__ / __x86_64__ was perhaps because
> lib/raid6/algos.c is built not only for the kernel but also for
> testing the library code from userspace.
>
> However, lib/raid6/test/Makefile passes -DCONFIG_X86_{32,64} for
> this case. So, I do not see a reason to not use CONFIG option here.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Acked-by: H. Peter Anvin (Intel) <[email protected]>