2005-02-05 21:09:18

by Nigel Cunningham

[permalink] [raw]
Subject: Missing Select in NFS server support causes comile error

Hi.

This was picked up by a Suspend2 user.

Regards,

Nigel

-----Forwarded Message-----
> From: Peter Fr?hberger <[email protected]>
> > I get an error while compiling, the same config worked for earlier
> > releases for 2.6.11-rc2.
> > applied patches:
> > 2.6.11-rc3
> > swsusp2 2.1.6 for 2.6.11-rc3
> > OS: debian unstable
> > gcc version: gcc (GCC) 3.3.5 (Debian 1:3.3.5-8)
> >
> > LD init/built-in.o
> > LD .tmp_vmlinux1
> > fs/built-in.o(.text+0x7329f): In function `fh_verify':
> > : undefined reference to `export_op_default'
> > fs/built-in.o(.text+0x738b7): In function `fh_compose':
> > : undefined reference to `export_op_default'
> > fs/built-in.o(.text+0x73bb7): In function `fh_update':
> > : undefined reference to `export_op_default'
> > fs/built-in.o(.text+0x73e80): In function `_fh_update':
> > : undefined reference to `export_op_default'
> > fs/built-in.o(.text+0x78150): In function `check_export':
> > : undefined reference to `find_exported_dentry'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> >
> > thx
> > Peter
>
> okay, this was a problem in fs/Kconfig
> with the attached patch, it compiled fine for me
>
> --- linux-2.6.11-fritsch1/fs/Kconfig 2005-02-05 13:17:13.000000000 +0100
> +++ linux-2.6.11-fritsch1/fs/Kconfig 2005-02-05 13:17:54.000000000 +0100
> @@ -1400,6 +1400,7 @@
> tristate "NFS server support"
> depends on INET
> select LOCKD
> + select EXPORTFS
> select SUNRPC
> help
> If you want your Linux box to act as an NFS *server*, so that
> other
>
> thx
> Peter
--
Nigel Cunningham
Software Engineer, Canberra, Australia
http://www.cyclades.com

Ph: +61 (2) 6292 8028 Mob: +61 (417) 100 574


2005-02-05 21:24:19

by Nigel Cunningham

[permalink] [raw]
Subject: [PATCH] Missing Select in NFS server support causes comile error

Hi.

(Resent in a format that can be more easily applied).

This issues was picked up by Peter Fr?hberger.

If NFS server support is selected, but ExportFS is not, the following
compile time errors occur:

> > > LD init/built-in.o
> > > LD .tmp_vmlinux1
> > > fs/built-in.o(.text+0x7329f): In function `fh_verify':
> > > : undefined reference to `export_op_default'
> > > fs/built-in.o(.text+0x738b7): In function `fh_compose':
> > > : undefined reference to `export_op_default'
> > > fs/built-in.o(.text+0x73bb7): In function `fh_update':
> > > : undefined reference to `export_op_default'
> > > fs/built-in.o(.text+0x73e80): In function `_fh_update':
> > > : undefined reference to `export_op_default'
> > > fs/built-in.o(.text+0x78150): In function `check_export':
> > > : undefined reference to `find_exported_dentry'
> > > make[1]: *** [.tmp_vmlinux1] Error 1
> > >

Signed-off by: Nigel Cunningham <[email protected]>

diff -ruNp 990-select-exportfs-on-nfs-server-old/fs/Kconfig 990-select-exportfs-on-nfs-server-new/fs/Kconfig
--- 990-select-exportfs-on-nfs-server-old/fs/Kconfig 2005-02-03 22:33:40.000000000 +1100
+++ 990-select-exportfs-on-nfs-server-new/fs/Kconfig 2005-02-06 08:22:25.000000000 +1100
@@ -1400,6 +1400,7 @@ config NFSD
tristate "NFS server support"
depends on INET
select LOCKD
+ select EXPORTFS
select SUNRPC
help
If you want your Linux box to act as an NFS *server*, so that other

--
Nigel Cunningham
Software Engineer, Canberra, Australia
http://www.cyclades.com

Ph: +61 (2) 6292 8028 Mob: +61 (417) 100 574