2005-09-01 19:38:55

by Daniel Walker

Subject: [PATCH 2.6.13] Warning in the qla2xxx driver

Remove possible uninitialized "sg" field warning in the qla24xx driver

Signed-Off-By: Daniel Walker <[email protected]>

Index: linux-2.6.13/drivers/scsi/qla2xxx/qla_iocb.c
===================================================================
--- linux-2.6.13.orig/drivers/scsi/qla2xxx/qla_iocb.c 2005-08-28 23:41:01.000000000 +0000
+++ linux-2.6.13/drivers/scsi/qla2xxx/qla_iocb.c 2005-08-31 18:31:03.000000000 +0000
@@ -744,7 +744,7 @@ qla24xx_start_scsi(srb_t *sp)
uint32_t index;
uint32_t handle;
struct cmd_type_7 *cmd_pkt;
- struct scatterlist *sg;
+ struct scatterlist *sg = NULL;
uint16_t cnt;
uint16_t req_cnt;
uint16_t tot_dsds;

2005-09-08 15:18:03

by Andrew Vasquez

Subject: Re: [PATCH 2.6.13] Warning in the qla2xxx driver

On Thu, 01 Sep 2005, Daniel Walker wrote:

> Remove possible uninitialized "sg" field warning in the qla24xx driver
>
> Signed-Off-By: Daniel Walker <[email protected]>
>
> Index: linux-2.6.13/drivers/scsi/qla2xxx/qla_iocb.c
> ===================================================================
> --- linux-2.6.13.orig/drivers/scsi/qla2xxx/qla_iocb.c 2005-08-28 23:41:01.000000000 +0000
> +++ linux-2.6.13/drivers/scsi/qla2xxx/qla_iocb.c 2005-08-31 18:31:03.000000000 +0000
> @@ -744,7 +744,7 @@ qla24xx_start_scsi(srb_t *sp)
> uint32_t index;
> uint32_t handle;
> struct cmd_type_7 *cmd_pkt;
> - struct scatterlist *sg;
> + struct scatterlist *sg = NULL;
> uint16_t cnt;
> uint16_t req_cnt;
> uint16_t tot_dsds;

This was already addressed in the following patch:

http://marc.theaimsgroup.com/?l=linux-scsi&m=112510857722632&w=2

which was recently pull by Linus:

http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=131736d34ebc3251d79ddfd08a5e57a3e86decd4

--
av