2006-08-08 03:26:12

by Greg Banks

[permalink] [raw]
Subject: [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports

cpumask: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL to export
node_2_cpu_mask. Thanks to Zwane Mwaikambo for pointing this out.

Signed-off-by: Greg Banks <[email protected]>
---

arch/i386/kernel/smpboot.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
===================================================================
--- linux-2.6.18-rc2.orig/arch/i386/kernel/smpboot.c
+++ linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
@@ -609,7 +609,7 @@ extern struct {
/* which logical CPUs are on which nodes */
cpumask_t node_2_cpu_mask[MAX_NUMNODES] __read_mostly =
{ [0 ... MAX_NUMNODES-1] = CPU_MASK_NONE };
-EXPORT_SYMBOL(node_2_cpu_mask);
+EXPORT_SYMBOL_GPL(node_2_cpu_mask);
/* which node each logical CPU is on */
int cpu_2_node[NR_CPUS] __read_mostly = { [0 ... NR_CPUS-1] = 0 };
EXPORT_SYMBOL(cpu_2_node);


Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.



2006-08-08 03:39:32

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports

On Tue, 08 Aug 2006 13:25:34 +1000
Greg Banks <[email protected]> wrote:

> cpumask: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL to export
> node_2_cpu_mask. Thanks to Zwane Mwaikambo for pointing this out.
>
> Signed-off-by: Greg Banks <[email protected]>
> ---
>
> arch/i386/kernel/smpboot.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
> ===================================================================
> --- linux-2.6.18-rc2.orig/arch/i386/kernel/smpboot.c
> +++ linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
> @@ -609,7 +609,7 @@ extern struct {
> /* which logical CPUs are on which nodes */
> cpumask_t node_2_cpu_mask[MAX_NUMNODES] __read_mostly =
> { [0 ... MAX_NUMNODES-1] = CPU_MASK_NONE };
> -EXPORT_SYMBOL(node_2_cpu_mask);
> +EXPORT_SYMBOL_GPL(node_2_cpu_mask);
> /* which node each logical CPU is on */
> int cpu_2_node[NR_CPUS] __read_mostly = { [0 ... NR_CPUS-1] = 0 };
> EXPORT_SYMBOL(cpu_2_node);

All the existing exports in lib/cpumask.c are EXPORT_SYMBOL() so I'd be
inclined to make any new exports match that.

<edits the diffs>

OK?

2006-08-08 03:41:06

by Greg Banks

[permalink] [raw]
Subject: Re: [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports

On Tue, 2006-08-08 at 13:39, Andrew Morton wrote:
> All the existing exports in lib/cpumask.c are EXPORT_SYMBOL() so I'd be
> inclined to make any new exports match that.
>
> <edits the diffs>
>
> OK?

Fine by me.

Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.


2006-08-08 03:48:46

by Paul Jackson

[permalink] [raw]
Subject: Re: [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports

> All the existing exports in lib/cpumask.c are EXPORT_SYMBOL() so I'd be
> inclined to make any new exports match that.
>
> OK?

ok here too

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <[email protected]> 1.925.600.0401