2006-10-21 15:07:11

by Andy Whitcroft

Subject: [PATCH] s390 move to using ktermios structure

Seem to be getting compile failures due to the switch to ktermios
in the serial subsystem. Need this to get S390 to build on
latest -mm's.

Not sure if this is all thats needed? Perhaps someone who groks
this architecture better can confirm.

-apw
=== 8< ===
s390: move to using ktermios structure

The new serial framwork uses the ktermios structure, switch s390 to
use that.

Signed-off-by: Andy Whitcroft <[email protected]>
---
diff --git a/drivers/s390/char/sclp_tty.c b/drivers/s390/char/sclp_tty.c
index 6f43e04..1421087 100644
--- a/drivers/s390/char/sclp_tty.c
+++ b/drivers/s390/char/sclp_tty.c
@@ -60,7 +60,7 @@ static unsigned short int sclp_tty_chars

struct tty_driver *sclp_tty_driver;

-extern struct termios tty_std_termios;
+extern struct ktermios tty_std_termios;

static struct sclp_ioctls sclp_ioctls;
static struct sclp_ioctls sclp_ioctls_init =

2006-10-23 08:44:33

by Martin Schwidefsky

Subject: Re: [PATCH] s390 move to using ktermios structure

On Sat, 2006-10-21 at 16:05 +0100, Andy Whitcroft wrote:
> Seem to be getting compile failures due to the switch to ktermios
> in the serial subsystem. Need this to get S390 to build on
> latest -mm's.
>
> Not sure if this is all thats needed? Perhaps someone who groks
> this architecture better can confirm.

A number of people have stumbled over the ktermios struct. The preferred
solution is to remove the declaration of tty_std_termios because it is
already declared in a header file.

--
blue skies,
Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.