2007-05-09 11:21:37

by Martin Schwidefsky

[permalink] [raw]
Subject: Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

On Mon, 2007-04-23 at 10:45 -0700, Andrew Morton wrote:
> > Andrew: I plan to add patches 1-5 to the for-andrew branch of the
> > git390 repository if that is fine with you. The only thing that will
> > be missing in the tree is the patch that disables wireless for s390.
> > The code does compile but without hardware it is mute to have the
> > config options. I'll wait until the git-wireless.patch is upstream.
> > Patches 7-9 depend on patches found in -mm.
> >
>
> umm, OK. If it's Ok I think I'll duck it for now: -mm is full.
>
> Over-full, really: I've been working basically continuously since Friday
> getting the current dungpile to compile and boot, and it's still miles away
> from that.

Is -mm less full now? I've seen you dropped your third patch bomb, so
maybe there is room now ..
I regenerated the kconfig patches. They fit on top of todays git but
they do have some rejects on 2.6.21-mm1. The rejects are trivial to fix,
but there are about 10 of them.

So when will be a good time to add the Kconfig patches to git390?
And do you prefer to let them rot^H^H^Hmature in -mm for a while before
they can go upstream?

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.



2007-05-09 16:37:27

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

On Wed, 09 May 2007 13:21:50 +0200 Martin Schwidefsky <[email protected]> wrote:

> On Mon, 2007-04-23 at 10:45 -0700, Andrew Morton wrote:
> > > Andrew: I plan to add patches 1-5 to the for-andrew branch of the
> > > git390 repository if that is fine with you. The only thing that will
> > > be missing in the tree is the patch that disables wireless for s390.
> > > The code does compile but without hardware it is mute to have the
> > > config options. I'll wait until the git-wireless.patch is upstream.
> > > Patches 7-9 depend on patches found in -mm.
> > >
> >
> > umm, OK. If it's Ok I think I'll duck it for now: -mm is full.
> >
> > Over-full, really: I've been working basically continuously since Friday
> > getting the current dungpile to compile and boot, and it's still miles away
> > from that.
>
> Is -mm less full now? I've seen you dropped your third patch bomb, so
> maybe there is room now ..

Near 500 patches, which is the lowest it's been in years. I do appear to
have a few hundred patch-bearing emails saved away though.

> I regenerated the kconfig patches. They fit on top of todays git but
> they do have some rejects on 2.6.21-mm1. The rejects are trivial to fix,
> but there are about 10 of them.
>
> So when will be a good time to add the Kconfig patches to git390?

Go wild.

> And do you prefer to let them rot^H^H^Hmature in -mm for a while before
> they can go upstream?

Your call. I'd be inclined to push them early personally - Kconfig
problems tend to be easy to spot and easy to fix and there's ample time to
fine tune it.

2007-05-10 07:25:28

by Martin Schwidefsky

[permalink] [raw]
Subject: Re: [PATCH 0/9] Kconfig: cleanup s390 v2.

On Wed, 2007-05-09 at 09:35 -0700, Andrew Morton wrote:
> > So when will be a good time to add the Kconfig patches to git390?
>
> Go wild.
>
> > And do you prefer to let them rot^H^H^Hmature in -mm for a while before
> > they can go upstream?
>
> Your call. I'd be inclined to push them early personally - Kconfig
> problems tend to be easy to spot and easy to fix and there's ample time to
> fine tune it.

Ok, that is my feeling as well. The patches won't get better by waiting.
I will add them to the for-linus/for-andrew branches and include them in
the next please-pull for Linus. Be prepared for some breakage in -mm..

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.