2008-03-05 00:51:56

by Joe Perches

Subject: [PATCH] include/asm-arm - use angle brackets for includes

Signed-off-by: Joe Perches <[email protected]

include/asm-arm/plat-s3c/uncompress.h | 4 ++--
include/asm-arm/proc-fns.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/asm-arm/plat-s3c/uncompress.h b/include/asm-arm/plat-s3c/uncompress.h
index b5e6208..19b9eda 100644
--- a/include/asm-arm/plat-s3c/uncompress.h
+++ b/include/asm-arm/plat-s3c/uncompress.h
@@ -27,8 +27,8 @@ static void arch_detect_cpu(void);

/* defines for UART registers */

-#include "asm/plat-s3c/regs-serial.h"
-#include "asm/plat-s3c/regs-watchdog.h"
+#include <asm/plat-s3c/regs-serial.h>
+#include <asm/plat-s3c/regs-watchdog.h>

/* working in physical space... */
#undef S3C2410_WDOGREG
diff --git a/include/asm-arm/proc-fns.h b/include/asm-arm/proc-fns.h
index a4ce457..75ec760 100644
--- a/include/asm-arm/proc-fns.h
+++ b/include/asm-arm/proc-fns.h
@@ -214,9 +214,9 @@
#ifndef __ASSEMBLY__

#ifndef MULTI_CPU
-#include "asm/cpu-single.h"
+#include <asm/cpu-single.h>
#else
-#include "asm/cpu-multi32.h"
+#include <asm/cpu-multi32.h>
#endif

#include <asm/memory.h>

2008-03-05 07:48:22

by Russell King

Subject: Re: [PATCH] include/asm-arm - use angle brackets for includes

To: Russell King <[email protected]>, Nicolas Pitre <[email protected]>
Cc: [email protected],
LKML <[email protected]>

No idea why you're sending this to Nicolas, yet it touches s3cXXXX stuff
which is Ben Dooks, who has been omitted from the above.

On Tue, Mar 04, 2008 at 04:46:18PM -0800, Joe Perches wrote:
> Signed-off-by: Joe Perches <[email protected]

This is not a proper signed off - please use both angle brackets. 8)

>
> include/asm-arm/plat-s3c/uncompress.h | 4 ++--
> include/asm-arm/proc-fns.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/asm-arm/plat-s3c/uncompress.h b/include/asm-arm/plat-s3c/uncompress.h
> index b5e6208..19b9eda 100644
> --- a/include/asm-arm/plat-s3c/uncompress.h
> +++ b/include/asm-arm/plat-s3c/uncompress.h
> @@ -27,8 +27,8 @@ static void arch_detect_cpu(void);
>
> /* defines for UART registers */
>
> -#include "asm/plat-s3c/regs-serial.h"
> -#include "asm/plat-s3c/regs-watchdog.h"
> +#include <asm/plat-s3c/regs-serial.h>
> +#include <asm/plat-s3c/regs-watchdog.h>
>
> /* working in physical space... */
> #undef S3C2410_WDOGREG
> diff --git a/include/asm-arm/proc-fns.h b/include/asm-arm/proc-fns.h
> index a4ce457..75ec760 100644
> --- a/include/asm-arm/proc-fns.h
> +++ b/include/asm-arm/proc-fns.h
> @@ -214,9 +214,9 @@
> #ifndef __ASSEMBLY__
>
> #ifndef MULTI_CPU
> -#include "asm/cpu-single.h"
> +#include <asm/cpu-single.h>
> #else
> -#include "asm/cpu-multi32.h"
> +#include <asm/cpu-multi32.h>
> #endif
>
> #include <asm/memory.h>
>
>

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:

2008-03-05 16:48:09

by Joe Perches

Subject: Re: [PATCH] include/asm-arm - use angle brackets for includes

Signature too...

Signed-off-by: Joe Perches <[email protected]>

include/asm-arm/plat-s3c/uncompress.h | 4 ++--
include/asm-arm/proc-fns.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/asm-arm/plat-s3c/uncompress.h b/include/asm-arm/plat-s3c/uncompress.h
index b5e6208..19b9eda 100644
--- a/include/asm-arm/plat-s3c/uncompress.h
+++ b/include/asm-arm/plat-s3c/uncompress.h
@@ -27,8 +27,8 @@ static void arch_detect_cpu(void);

/* defines for UART registers */

-#include "asm/plat-s3c/regs-serial.h"
-#include "asm/plat-s3c/regs-watchdog.h"
+#include <asm/plat-s3c/regs-serial.h>
+#include <asm/plat-s3c/regs-watchdog.h>

/* working in physical space... */
#undef S3C2410_WDOGREG
diff --git a/include/asm-arm/proc-fns.h b/include/asm-arm/proc-fns.h
index a4ce457..75ec760 100644
--- a/include/asm-arm/proc-fns.h
+++ b/include/asm-arm/proc-fns.h
@@ -214,9 +214,9 @@
#ifndef __ASSEMBLY__

#ifndef MULTI_CPU
-#include "asm/cpu-single.h"
+#include <asm/cpu-single.h>
#else
-#include "asm/cpu-multi32.h"
+#include <asm/cpu-multi32.h>
#endif

#include <asm/memory.h>

2008-03-06 09:15:09

by Russell King

Subject: Re: [PATCH] include/asm-arm - use angle brackets for includes

On Wed, Mar 05, 2008 at 08:44:13AM -0800, Joe Perches wrote:
> Signature too...
>
> Signed-off-by: Joe Perches <[email protected]>

Applied, thanks.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: