2017-09-27 17:23:01

by SF Markus Elfring

Subject: [PATCH] clk/ti: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring <[email protected]>
Date: Wed, 27 Sep 2017 19:14:01 +0200

Omit extra messages for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/clk/ti/divider.c | 4 +---
drivers/clk/ti/mux.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/clk/ti/divider.c b/drivers/clk/ti/divider.c
index 88f04a4cb890..77f93f6d2806 100644
--- a/drivers/clk/ti/divider.c
+++ b/drivers/clk/ti/divider.c
@@ -292,10 +292,8 @@ static struct clk *_register_divider(struct device *dev, const char *name,

/* allocate the divider */
div = kzalloc(sizeof(*div), GFP_KERNEL);
- if (!div) {
- pr_err("%s: could not allocate divider clk\n", __func__);
+ if (!div)
return ERR_PTR(-ENOMEM);
- }

init.name = name;
init.ops = &ti_clk_divider_ops;
diff --git a/drivers/clk/ti/mux.c b/drivers/clk/ti/mux.c
index 18c267b38461..d4705803f3d3 100644
--- a/drivers/clk/ti/mux.c
+++ b/drivers/clk/ti/mux.c
@@ -108,10 +108,8 @@ static struct clk *_register_mux(struct device *dev, const char *name,

/* allocate the mux */
mux = kzalloc(sizeof(*mux), GFP_KERNEL);
- if (!mux) {
- pr_err("%s: could not allocate mux clk\n", __func__);
+ if (!mux)
return ERR_PTR(-ENOMEM);
- }

init.name = name;
init.ops = &ti_clk_mux_ops;
--
2.14.2

2017-11-14 02:01:56

by Stephen Boyd

Subject: Re: [PATCH] clk/ti: Delete an error message for a failed memory allocation in two functions

On 09/27, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Wed, 27 Sep 2017 19:14:01 +0200
>
> Omit extra messages for a memory allocation failure in these functions.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---

Applied to clk-next

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

From 1579714377851533432@xxx Wed Sep 27 17:23:49 +0000 2017
X-GM-THRID: 1579714377851533432
X-Gmail-Labels: Inbox,Category Forums