2008-10-17 17:46:48

by Badari Pulavarty

[permalink] [raw]
Subject: 2.6.27-git7 compile error (ppc)

Hi,

I get this following compile error on my ppc box.

Let me know if its a known issue. Otherwise, I can figure out
whats happening.

Thanks,
Badari

CC arch/powerpc/mm/slb.o
In file included from /usr/src/linux-2.6.27/arch/powerpc/include/asm/mmu-hash64.h:16,
from /usr/src/linux-2.6.27/arch/powerpc/include/asm/mmu.h:7,
from /usr/src/linux-2.6.27/arch/powerpc/include/asm/pgtable.h:7,
from arch/powerpc/mm/slb.c:19:
/usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:76: error: parse error before "memstart_addr"
/usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:76: warning: type defaults to `int' in declaration of `memstart_addr'
/usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:76: warning: data definition has no type or storage class
/usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:77: error: parse error before "kernstart_addr"
/usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:77: warning: type defaults to `int' in declaration of `kernstart_addr'
/usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:77: warning: data definition has no type or storage class
AS arch/powerpc/lib/string.o
CC arch/powerpc/lib/alloc.o
CALL arch/powerpc/kernel/systbl_chk.sh
CC arch/powerpc/kernel/sysfs.o
make[1]: *** [arch/powerpc/mm/slb.o] Error 1
make: *** [arch/powerpc/mm] Error 2
make: *** Waiting for unfinished jobs....


2008-10-17 18:10:48

by Badari Pulavarty

[permalink] [raw]
Subject: Re: 2.6.27-git7 compile error (ppc)

On Fri, 2008-10-17 at 10:47 -0700, Badari Pulavarty wrote:
> Hi,
>
> I get this following compile error on my ppc box.
>
> Let me know if its a known issue. Otherwise, I can figure out
> whats happening.
>
> Thanks,
> Badari

This is due to recent changes to move phys_add_t definition from
arch/powerpc/include/asm/types.h to include/linux/types.h.

arch/powerpc/include/asm/page.h needs phys_addr_t for
CONFIG_RELOCATABLE. Needs fixing..

Thanks,
Badari

>
> CC arch/powerpc/mm/slb.o
> In file included from /usr/src/linux-2.6.27/arch/powerpc/include/asm/mmu-hash64.h:16,
> from /usr/src/linux-2.6.27/arch/powerpc/include/asm/mmu.h:7,
> from /usr/src/linux-2.6.27/arch/powerpc/include/asm/pgtable.h:7,
> from arch/powerpc/mm/slb.c:19:
> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:76: error: parse error before "memstart_addr"
> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:76: warning: type defaults to `int' in declaration of `memstart_addr'
> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:76: warning: data definition has no type or storage class
> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:77: error: parse error before "kernstart_addr"
> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:77: warning: type defaults to `int' in declaration of `kernstart_addr'
> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:77: warning: data definition has no type or storage class
> AS arch/powerpc/lib/string.o
> CC arch/powerpc/lib/alloc.o
> CALL arch/powerpc/kernel/systbl_chk.sh
> CC arch/powerpc/kernel/sysfs.o
> make[1]: *** [arch/powerpc/mm/slb.o] Error 1
> make: *** [arch/powerpc/mm] Error 2
> make: *** Waiting for unfinished jobs....
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2008-10-17 20:38:01

by Kumar Gala

[permalink] [raw]
Subject: Re: 2.6.27-git7 compile error (ppc)


On Oct 17, 2008, at 1:11 PM, Badari Pulavarty wrote:

> On Fri, 2008-10-17 at 10:47 -0700, Badari Pulavarty wrote:
>> Hi,
>>
>> I get this following compile error on my ppc box.
>>
>> Let me know if its a known issue. Otherwise, I can figure out
>> whats happening.
>>
>> Thanks,
>> Badari
>
> This is due to recent changes to move phys_add_t definition from
> arch/powerpc/include/asm/types.h to include/linux/types.h.
>
> arch/powerpc/include/asm/page.h needs phys_addr_t for
> CONFIG_RELOCATABLE. Needs fixing..
>
> Thanks,
> Badari
>
>>
>> CC arch/powerpc/mm/slb.o
>> In file included from /usr/src/linux-2.6.27/arch/powerpc/include/
>> asm/mmu-hash64.h:16,
>> from /usr/src/linux-2.6.27/arch/powerpc/include/asm/
>> mmu.h:7,
>> from /usr/src/linux-2.6.27/arch/powerpc/include/asm/
>> pgtable.h:7,
>> from arch/powerpc/mm/slb.c:19:
>> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:76: error:
>> parse error before "memstart_addr"
>> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:76: warning:
>> type defaults to `int' in declaration of `memstart_addr'
>> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:76: warning:
>> data definition has no type or storage class
>> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:77: error:
>> parse error before "kernstart_addr"
>> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:77: warning:
>> type defaults to `int' in declaration of `kernstart_addr'
>> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:77: warning:
>> data definition has no type or storage class
>> AS arch/powerpc/lib/string.o
>> CC arch/powerpc/lib/alloc.o
>> CALL arch/powerpc/kernel/systbl_chk.sh
>> CC arch/powerpc/kernel/sysfs.o
>> make[1]: *** [arch/powerpc/mm/slb.o] Error 1
>> make: *** [arch/powerpc/mm] Error 2
>> make: *** Waiting for unfinished jobs....

I've got a patch that seems to address this for me building w/
CONFIG_RELOCATABLE on ppc32/85xx.

- k

2008-10-24 22:49:29

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: 2.6.27-git7 compile error (ppc)

On Friday, 17 of October 2008, Kumar Gala wrote:
>
> On Oct 17, 2008, at 1:11 PM, Badari Pulavarty wrote:
>
> > On Fri, 2008-10-17 at 10:47 -0700, Badari Pulavarty wrote:
> >> Hi,
> >>
> >> I get this following compile error on my ppc box.
> >>
> >> Let me know if its a known issue. Otherwise, I can figure out
> >> whats happening.
> >>
> >> Thanks,
> >> Badari
> >
> > This is due to recent changes to move phys_add_t definition from
> > arch/powerpc/include/asm/types.h to include/linux/types.h.
> >
> > arch/powerpc/include/asm/page.h needs phys_addr_t for
> > CONFIG_RELOCATABLE. Needs fixing..
> >
> > Thanks,
> > Badari
> >
> >>
> >> CC arch/powerpc/mm/slb.o
> >> In file included from /usr/src/linux-2.6.27/arch/powerpc/include/
> >> asm/mmu-hash64.h:16,
> >> from /usr/src/linux-2.6.27/arch/powerpc/include/asm/
> >> mmu.h:7,
> >> from /usr/src/linux-2.6.27/arch/powerpc/include/asm/
> >> pgtable.h:7,
> >> from arch/powerpc/mm/slb.c:19:
> >> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:76: error:
> >> parse error before "memstart_addr"
> >> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:76: warning:
> >> type defaults to `int' in declaration of `memstart_addr'
> >> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:76: warning:
> >> data definition has no type or storage class
> >> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:77: error:
> >> parse error before "kernstart_addr"
> >> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:77: warning:
> >> type defaults to `int' in declaration of `kernstart_addr'
> >> /usr/src/linux-2.6.27/arch/powerpc/include/asm/page.h:77: warning:
> >> data definition has no type or storage class
> >> AS arch/powerpc/lib/string.o
> >> CC arch/powerpc/lib/alloc.o
> >> CALL arch/powerpc/kernel/systbl_chk.sh
> >> CC arch/powerpc/kernel/sysfs.o
> >> make[1]: *** [arch/powerpc/mm/slb.o] Error 1
> >> make: *** [arch/powerpc/mm] Error 2
> >> make: *** Waiting for unfinished jobs....
>
> I've got a patch that seems to address this for me building w/
> CONFIG_RELOCATABLE on ppc32/85xx.

Has that been fixed in 2.6.27 and/or current mainline?

Rafael

2008-10-24 22:56:44

by Chris Friesen

[permalink] [raw]
Subject: Re: 2.6.27-git7 compile error (ppc)

Rafael J. Wysocki wrote:
> On Friday, 17 of October 2008, Kumar Gala wrote:

>> I've got a patch that seems to address this for me building w/
>> CONFIG_RELOCATABLE on ppc32/85xx.
>
> Has that been fixed in 2.6.27 and/or current mainline?

I think CONFIG_RELOCATABLE was introduced post 2.6.27, so shouldn't be a
problem in that version.

Chris

2008-10-25 00:01:53

by Badari Pulavarty

[permalink] [raw]
Subject: Re: 2.6.27-git7 compile error (ppc)

On Fri, 2008-10-24 at 16:55 -0600, Chris Friesen wrote:
> Rafael J. Wysocki wrote:
> > On Friday, 17 of October 2008, Kumar Gala wrote:
>
> >> I've got a patch that seems to address this for me building w/
> >> CONFIG_RELOCATABLE on ppc32/85xx.
> >
> > Has that been fixed in 2.6.27 and/or current mainline?
>
> I think CONFIG_RELOCATABLE was introduced post 2.6.27, so shouldn't be a
> problem in that version.
>
> Chris

Not quite true. CONFIG_RELOCATABLE is present in 2.6.27, but the changes
to types.h happend post 2.6.27 - so there is no problem with 2.6.27.

2.6.27-git11 compiles fine.

Thanks,
Badari