2009-04-27 08:16:19

by Christoph Hellwig

[permalink] [raw]
Subject: missing preadv/pwritev wireup

2.6.30 added the new preadv/pwritev system calls. The following
architectures still haven't wired them up:

alpha, avr32, blackfin, cris, frv, h8300, m32r, xtensa

Can you maintainers please look into wiring these system calls up?


2009-04-27 18:27:15

by Mike Frysinger

[permalink] [raw]
Subject: [PATCH] Blackfin: hook up preadv/pwritev syscalls

Signed-off-by: Mike Frysinger <[email protected]>
---
arch/blackfin/include/asm/unistd.h | 4 +++-
arch/blackfin/mach-common/entry.S | 2 ++
2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/arch/blackfin/include/asm/unistd.h b/arch/blackfin/include/asm/unistd.h
index 1e57b63..cf5066d 100644
--- a/arch/blackfin/include/asm/unistd.h
+++ b/arch/blackfin/include/asm/unistd.h
@@ -378,8 +378,10 @@
#define __NR_dup3 363
#define __NR_pipe2 364
#define __NR_inotify_init1 365
+#define __NR_preadv 366
+#define __NR_pwritev 367

-#define __NR_syscall 366
+#define __NR_syscall 368
#define NR_syscalls __NR_syscall

/* Old optional stuff no one actually uses */
diff --git a/arch/blackfin/mach-common/entry.S b/arch/blackfin/mach-common/entry.S
index 21e65a3..a063a43 100644
--- a/arch/blackfin/mach-common/entry.S
+++ b/arch/blackfin/mach-common/entry.S
@@ -1581,6 +1581,8 @@ ENTRY(_sys_call_table)
.long _sys_dup3
.long _sys_pipe2
.long _sys_inotify_init1 /* 365 */
+ .long _sys_preadv
+ .long _sys_pwritev

.rept NR_syscalls-(.-_sys_call_table)/4
.long _sys_ni_syscall
--
1.6.2.3

2009-04-28 15:59:21

by Jesper Nilsson

[permalink] [raw]
Subject: [PATCH] CRIS: Wire up syscalls signalfd4 to writev.

On Mon, Apr 27, 2009 at 10:13:56AM +0200, Christoph Hellwig wrote:
> 2.6.30 added the new preadv/pwritev system calls. The following
> architectures still haven't wired them up:
>
> alpha, avr32, blackfin, cris, frv, h8300, m32r, xtensa
>
> Can you maintainers please look into wiring these system calls up?

I've just added the following patch to the CRIS tree:


Adds sys_signalfd4, sys_eventfd2, sys_epoll_create1, sys_dup3,
sys_pipe2, sys_inotify_init1, sys_preadv, sys_pwritev
for both CRISv10 and CRISv32.

Signed-off-by: Jesper Nilsson <[email protected]>
---
arch/cris/arch-v10/kernel/entry.S | 14 +++++++++++---
arch/cris/arch-v32/kernel/entry.S | 8 ++++++++
arch/cris/include/asm/unistd.h | 12 ++++++++++--
3 files changed, 29 insertions(+), 5 deletions(-)

diff --git a/arch/cris/arch-v10/kernel/entry.S b/arch/cris/arch-v10/kernel/entry.S
index 72f5cd3..2c18d08 100644
--- a/arch/cris/arch-v10/kernel/entry.S
+++ b/arch/cris/arch-v10/kernel/entry.S
@@ -536,10 +536,10 @@ multiple_interrupt:
movem $r13, [$sp]
push $r10 ; push orig_r10
clear.d [$sp=$sp-4] ; frametype == 0, normal frame
-
+
move.d $sp, $r10
jsr do_multiple_IRQ
-
+
jump ret_from_intr

do_sigtrap:
@@ -585,7 +585,7 @@ _ugdb_handle_breakpoint:
pop $r0 ; Restore r0.
ba do_sigtrap ; SIGTRAP the offending process.
pop $dccr ; Restore dccr in delay slot.
-
+
.global kernel_execve
kernel_execve:
move.d __NR_execve, $r9
@@ -929,6 +929,14 @@ sys_call_table:
.long sys_fallocate
.long sys_timerfd_settime /* 325 */
.long sys_timerfd_gettime
+ .long sys_signalfd4
+ .long sys_eventfd2
+ .long sys_epoll_create1
+ .long sys_dup3 /* 330 */
+ .long sys_pipe2
+ .long sys_inotify_init1
+ .long sys_preadv
+ .long sys_pwritev

/*
* NOTE!! This doesn't have to be exact - we just have
diff --git a/arch/cris/arch-v32/kernel/entry.S b/arch/cris/arch-v32/kernel/entry.S
index 5e674c8..435b967 100644
--- a/arch/cris/arch-v32/kernel/entry.S
+++ b/arch/cris/arch-v32/kernel/entry.S
@@ -852,6 +852,14 @@ sys_call_table:
.long sys_fallocate
.long sys_timerfd_settime /* 325 */
.long sys_timerfd_gettime
+ .long sys_signalfd4
+ .long sys_eventfd2
+ .long sys_epoll_create1
+ .long sys_dup3 /* 330 */
+ .long sys_pipe2
+ .long sys_inotify_init1
+ .long sys_preadv
+ .long sys_pwritev

/*
* NOTE!! This doesn't have to be exact - we just have
diff --git a/arch/cris/include/asm/unistd.h b/arch/cris/include/asm/unistd.h
index 235d076..c170793 100644
--- a/arch/cris/include/asm/unistd.h
+++ b/arch/cris/include/asm/unistd.h
@@ -281,7 +281,7 @@
#define __NR_mbind 274
#define __NR_get_mempolicy 275
#define __NR_set_mempolicy 276
-#define __NR_mq_open 277
+#define __NR_mq_open 277
#define __NR_mq_unlink (__NR_mq_open+1)
#define __NR_mq_timedsend (__NR_mq_open+2)
#define __NR_mq_timedreceive (__NR_mq_open+3)
@@ -331,10 +331,18 @@
#define __NR_fallocate 324
#define __NR_timerfd_settime 325
#define __NR_timerfd_gettime 326
+#define __NR_signalfd4 327
+#define __NR_eventfd2 328
+#define __NR_epoll_create1 329
+#define __NR_dup3 330
+#define __NR_pipe2 331
+#define __NR_inotify_init1 332
+#define __NR_preadv 333
+#define __NR_pwritev 334

#ifdef __KERNEL__

-#define NR_syscalls 327
+#define NR_syscalls 335

#include <arch/unistd.h>

--
1.6.1


/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]

2009-04-28 16:01:24

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH] CRIS: Wire up syscalls signalfd4 to writev.

On Tue, Apr 28, 2009 at 05:58:56PM +0200, Jesper Nilsson wrote:
> On Mon, Apr 27, 2009 at 10:13:56AM +0200, Christoph Hellwig wrote:
> > 2.6.30 added the new preadv/pwritev system calls. The following
> > architectures still haven't wired them up:
> >
> > alpha, avr32, blackfin, cris, frv, h8300, m32r, xtensa
> >
> > Can you maintainers please look into wiring these system calls up?
>
> I've just added the following patch to the CRIS tree:
>
>
> Adds sys_signalfd4, sys_eventfd2, sys_epoll_create1, sys_dup3,
> sys_pipe2, sys_inotify_init1, sys_preadv, sys_pwritev
> for both CRISv10 and CRISv32.

Care to send this and your current stack of patches upsteam before
2.6.30 is out?

2009-04-28 16:09:11

by Jesper Nilsson

[permalink] [raw]
Subject: Re: [PATCH] CRIS: Wire up syscalls signalfd4 to writev.

On Tue, Apr 28, 2009 at 06:01:07PM +0200, Christoph Hellwig wrote:
> On Tue, Apr 28, 2009 at 05:58:56PM +0200, Jesper Nilsson wrote:
> > On Mon, Apr 27, 2009 at 10:13:56AM +0200, Christoph Hellwig wrote:
> > > 2.6.30 added the new preadv/pwritev system calls. The following
> > > architectures still haven't wired them up:
> > >
> > > alpha, avr32, blackfin, cris, frv, h8300, m32r, xtensa
> > >
> > > Can you maintainers please look into wiring these system calls up?
> >
> > I've just added the following patch to the CRIS tree:
> >
> >
> > Adds sys_signalfd4, sys_eventfd2, sys_epoll_create1, sys_dup3,
> > sys_pipe2, sys_inotify_init1, sys_preadv, sys_pwritev
> > for both CRISv10 and CRISv32.
>
> Care to send this and your current stack of patches upsteam before
> 2.6.30 is out?

Will do, I'll let it sit for a day in linux-next first.

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]