Hi,
On Tue, 2009-06-23 at 15:16 +0300, Aviv Laufer wrote:
> I have found a bug in tdo24m.c .
> There is a call to kmalloc with the second param is sizeeof (flag)
> instead of flag.
> This cause a crash.
Thats quite a nasty bug and its surprising its not been found before
now! Can you resubmit the patch with description and most importantly a
Signed-off-by line please (see Documentation/SubmittingPatches)?
Cheers,
Richard
--
Richard Purdie
Intel Open Source Technology Centre
Richard Purdie wrote:
> Hi,
>
> On Tue, 2009-06-23 at 15:16 +0300, Aviv Laufer wrote:
>> I have found a bug in tdo24m.c .
>> There is a call to kmalloc with the second param is sizeeof (flag)
>> instead of flag.
>> This cause a crash.
>
> Thats quite a nasty bug and its surprising its not been found before
> now! Can you resubmit the patch with description and most importantly a
> Signed-off-by line please (see Documentation/SubmittingPatches)?
>
Ooops - this is embarrassing, yet I didn't find this causing any crash
by now, tdo24m works just OK on my Littleton and thus hiding this bug
deeply.
Aviv,
Any update on this patch? I'd like to queue this ASAP.
Hi,
I tested in on my PXA-270 board.
The patch was submitted and I guess it's waiting for approval
Aviv
On Mon, Jun 29, 2009 at 4:40 AM, Eric Miao<[email protected]> wrote:
> Richard Purdie wrote:
>> Hi,
>>
>> On Tue, 2009-06-23 at 15:16 +0300, Aviv Laufer wrote:
>>> I have found a bug in tdo24m.c .
>>> There is a call to kmalloc with the second param is sizeeof (flag)
>>> instead of flag.
>>> This cause ?a crash.
>>
>> Thats quite a nasty bug and its surprising its not been found before
>> now! Can you resubmit the patch with description and most importantly a
>> Signed-off-by line please (see Documentation/SubmittingPatches)?
>>
>
> Ooops - this is embarrassing, yet I didn't find this causing any crash
> by now, ?tdo24m works just OK on my Littleton and thus hiding this bug
> deeply.
>
> Aviv,
>
> Any update on this patch? I'd like to queue this ASAP.
>