2009-06-23 13:29:10

by Aviv Laufer

Subject: [PATCH] /drivers/video/backlight/tdo24m - crash on kmalloc

There is a crash in tdo24m module caused by a call to kmalloc with
the second parameter sizeof(flag) instead of flag.

Signed-off-by: Aviv Laufer <[email protected]>
---


--- linux-2.6.30/drivers/video/backlight/tdo24m.c.orig 2009-06-23
15:08:02.000000000 +0300
+++ linux-2.6.30/drivers/video/backlight/tdo24m.c 2009-06-23
15:09:05.000000000 +0300
@@ -356,7 +356,7 @@ static int __devinit tdo24m_probe(struct
lcd->power = FB_BLANK_POWERDOWN;
lcd->mode = MODE_VGA; /* default to VGA */

- lcd->buf = kmalloc(TDO24M_SPI_BUFF_SIZE, sizeof(GFP_KERNEL));
+ lcd->buf = kmalloc(TDO24M_SPI_BUFF_SIZE, GFP_KERNEL);
if (lcd->buf == NULL) {
kfree(lcd);
return -ENOMEM;

2009-06-23 19:55:49

by Richard Purdie

Subject: Re: [PATCH] /drivers/video/backlight/tdo24m - crash on kmalloc

On Tue, 2009-06-23 at 16:28 +0300, Aviv Laufer wrote:
> There is a crash in tdo24m module caused by a call to kmalloc with
> the second parameter sizeof(flag) instead of flag.
>
> Signed-off-by: Aviv Laufer <[email protected]>

Thanks, its been queued for Linus in the backlight tree.

Cheers,

Richard

--
Richard Purdie
Intel Open Source Technology Centre

2009-06-29 07:23:39

by Eric Miao

Subject: Re: [PATCH] /drivers/video/backlight/tdo24m - crash on kmalloc

Aviv Laufer wrote:
> There is a crash in tdo24m module caused by a call to kmalloc with
> the second parameter sizeof(flag) instead of flag.
>
> Signed-off-by: Aviv Laufer <[email protected]>

Acked-by: Eric Miao <[email protected]>

> ---
>
>
> --- linux-2.6.30/drivers/video/backlight/tdo24m.c.orig 2009-06-23
> 15:08:02.000000000 +0300
> +++ linux-2.6.30/drivers/video/backlight/tdo24m.c 2009-06-23
> 15:09:05.000000000 +0300
> @@ -356,7 +356,7 @@ static int __devinit tdo24m_probe(struct
> lcd->power = FB_BLANK_POWERDOWN;
> lcd->mode = MODE_VGA; /* default to VGA */
>
> - lcd->buf = kmalloc(TDO24M_SPI_BUFF_SIZE, sizeof(GFP_KERNEL));
> + lcd->buf = kmalloc(TDO24M_SPI_BUFF_SIZE, GFP_KERNEL);
> if (lcd->buf == NULL) {
> kfree(lcd);
> return -ENOMEM;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/