2010-04-14 02:16:05

by Huang Shijie

Subject: [PATCH][resend] namei.c : update mnt when it needed

update the mnt of the path when it is not equal to the new one.

Signed-off-by: Huang Shijie <[email protected]>
---
fs/namei.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index a7dce91..9c3a040 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -523,9 +523,10 @@ static void path_put_conditional(struct path *path, struct nameidata *nd)
static inline void path_to_nameidata(struct path *path, struct nameidata *nd)
{
dput(nd->path.dentry);
- if (nd->path.mnt != path->mnt)
+ if (nd->path.mnt != path->mnt) {
mntput(nd->path.mnt);
- nd->path.mnt = path->mnt;
+ nd->path.mnt = path->mnt;
+ }
nd->path.dentry = path->dentry;
}

--
1.6.6

2010-04-14 04:44:23

by Cong Wang

Subject: Re: [PATCH][resend] namei.c : update mnt when it needed

On Wed, Apr 14, 2010 at 10:16:09AM +0800, Huang Shijie wrote:
>update the mnt of the path when it is not equal to the new one.
>
>Signed-off-by: Huang Shijie <[email protected]>


This change is trivial, and it looks fine for me.

Reviewed-by: WANG Cong <[email protected]>

Thanks!


>---
> fs/namei.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/fs/namei.c b/fs/namei.c
>index a7dce91..9c3a040 100644
>--- a/fs/namei.c
>+++ b/fs/namei.c
>@@ -523,9 +523,10 @@ static void path_put_conditional(struct path *path, struct nameidata *nd)
> static inline void path_to_nameidata(struct path *path, struct nameidata *nd)
> {
> dput(nd->path.dentry);
>- if (nd->path.mnt != path->mnt)
>+ if (nd->path.mnt != path->mnt) {
> mntput(nd->path.mnt);
>- nd->path.mnt = path->mnt;
>+ nd->path.mnt = path->mnt;
>+ }
> nd->path.dentry = path->dentry;
> }
>
>--
>1.6.6
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to [email protected]
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/