2010-08-06 20:44:55

by Jason Wessel

[permalink] [raw]
Subject: [GIT PULL] kgdboc compile fix

Linus, please pull the for_linus which contains a compilation fix for
building without the kernel config option CONFIG_HW_CONSOLE.

git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb.git for_lin
us

There are some other fixes brewing, but this is the only known
compilation problem and I know we would like to keep the tree fully
bisectable.

Thanks,
Jason.

---
Jason Wessel (1):
console: Fix compilation regression

include/linux/console.h | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)


2010-08-06 20:44:47

by Jason Wessel

[permalink] [raw]
Subject: [PATCH 1/1] console: Fix compilation regression

A regression of building without CONFIG_HW_CONSOLE was introduced with
commit b45cfba4e9005d64d419718e7ff7f7cab44c1994 (vt,console,kdb:
implement atomic console enter/leave functions).

ERROR: "con_debug_enter" [drivers/serial/kgdboc.ko] undefined!
ERROR: "vc_cons" [drivers/serial/kgdboc.ko] undefined!
ERROR: "fg_console" [drivers/serial/kgdboc.ko] undefined!
ERROR: "con_debug_leave" [drivers/serial/kgdboc.ko] undefined!

When there is no HW console the con_debug_enter and con_debug_leave
functions should have no code.

Signed-off-by: Jason Wessel <[email protected]>
CC: Jesse Barnes <[email protected]>
Reported-by: Randy Dunlap <[email protected]>

---
include/linux/console.h | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/include/linux/console.h b/include/linux/console.h
index f76fc29..95cf6f0 100644
--- a/include/linux/console.h
+++ b/include/linux/console.h
@@ -79,8 +79,13 @@ int register_con_driver(const struct consw *csw, int first, int last);
int unregister_con_driver(const struct consw *csw);
int take_over_console(const struct consw *sw, int first, int last, int deflt);
void give_up_console(const struct consw *sw);
+#ifdef CONFIG_HW_CONSOLE
int con_debug_enter(struct vc_data *vc);
int con_debug_leave(void);
+#else
+#define con_debug_enter(vc) (0)
+#define con_debug_leave() (0)
+#endif

/* scroll */
#define SM_UP (1)
--
1.6.3.3