Recent kernels include an additional call to depmod during the installation
of external kernel modules as a convenience, in order to ensure that those
modules are picked up by the module loading tools/initramfs scripts, etc.
Although this call is potentially of some value, it should not be made
when explicitly setting INSTALL_MOD_PATH to a different location. This
avoids creating extraneous modules.* files that will never be used.
Signed-off-by: Jon Masters <[email protected]>
---
Makefile | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index f3bdff8..2b904f2 100644
--- a/Makefile
+++ b/Makefile
@@ -1325,7 +1325,9 @@ _emodinst_:
PHONY += _emodinst_post
_emodinst_post: _emodinst_
+ifeq ($(INSTALL_MOD_PATH),)
$(call cmd,depmod)
+endif
clean-dirs := $(addprefix _clean_,$(KBUILD_EXTMOD))
--
1.7.2.1
On Mon, 16 Aug 2010 05:33:34 pm Jon Masters wrote:
> Recent kernels include an additional call to depmod during the installation
> of external kernel modules as a convenience, in order to ensure that those
> modules are picked up by the module loading tools/initramfs scripts, etc.
> Although this call is potentially of some value, it should not be made
> when explicitly setting INSTALL_MOD_PATH to a different location. This
> avoids creating extraneous modules.* files that will never be used.
>
> Signed-off-by: Jon Masters <[email protected]>
Acked-by: Rusty Russell <[email protected]>
I leave the Makefile stuff to the kbuild people...
> ---
> Makefile | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index f3bdff8..2b904f2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1325,7 +1325,9 @@ _emodinst_:
>
> PHONY += _emodinst_post
> _emodinst_post: _emodinst_
> +ifeq ($(INSTALL_MOD_PATH),)
> $(call cmd,depmod)
> +endif
>
> clean-dirs := $(addprefix _clean_,$(KBUILD_EXTMOD))
Thanks,
Rusty.
On Mon, 2010-08-16 at 20:13 +0930, Rusty Russell wrote:
> On Mon, 16 Aug 2010 05:33:34 pm Jon Masters wrote:
> > Recent kernels include an additional call to depmod during the installation
> > of external kernel modules as a convenience, in order to ensure that those
> > modules are picked up by the module loading tools/initramfs scripts, etc.
> > Although this call is potentially of some value, it should not be made
> > when explicitly setting INSTALL_MOD_PATH to a different location. This
> > avoids creating extraneous modules.* files that will never be used.
> >
> > Signed-off-by: Jon Masters <[email protected]>
>
> Acked-by: Rusty Russell <[email protected]>
>
> I leave the Makefile stuff to the kbuild people...
Hey, thanks for forwarding. I figured I would do that, but I see you
already did. And yea, next time I'll ping the Kbuild folks directly.
Jon.
On Mon, Aug 16, 2010 at 08:13:45PM +0930, Rusty Russell wrote:
>On Mon, 16 Aug 2010 05:33:34 pm Jon Masters wrote:
>> Recent kernels include an additional call to depmod during the installation
>> of external kernel modules as a convenience, in order to ensure that those
>> modules are picked up by the module loading tools/initramfs scripts, etc.
>> Although this call is potentially of some value, it should not be made
>> when explicitly setting INSTALL_MOD_PATH to a different location. This
>> avoids creating extraneous modules.* files that will never be used.
>>
>> Signed-off-by: Jon Masters <[email protected]>
>
>Acked-by: Rusty Russell <[email protected]>
>
>I leave the Makefile stuff to the kbuild people...
>
Looks good for me,
Acked-by: WANG Cong <[email protected]>