2010-08-19 06:37:49

by Axel Lin

Subject: [PATCH] ASoC: e740_wm9705 - free gpio in e740_exit()

In e740_init(), we call gpio_request() for
GPIO_E740_MIC_ON, GPIO_E740_AMP_ON and GPIO_E740_WM9705_nAVDD2.
We should free the these gpio accordingly in e740_exit().

Signed-off-by: Axel Lin <[email protected]>
---
sound/soc/pxa/e740_wm9705.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/sound/soc/pxa/e740_wm9705.c b/sound/soc/pxa/e740_wm9705.c
index 7cd2f89..515faeb 100644
--- a/sound/soc/pxa/e740_wm9705.c
+++ b/sound/soc/pxa/e740_wm9705.c
@@ -200,6 +200,9 @@ free_mic_amp_gpio:
static void __exit e740_exit(void)
{
platform_device_unregister(e740_snd_device);
+ gpio_free(GPIO_E740_WM9705_nAVDD2);
+ gpio_free(GPIO_E740_AMP_ON);
+ gpio_free(GPIO_E740_MIC_ON);
}

module_init(e740_init);
--
1.7.2

2010-08-20 09:26:44

by Liam Girdwood

Subject: Re: [PATCH] ASoC: e740_wm9705 - free gpio in e740_exit()

On Thu, 2010-08-19 at 14:40 +0800, Axel Lin wrote:
> In e740_init(), we call gpio_request() for
> GPIO_E740_MIC_ON, GPIO_E740_AMP_ON and GPIO_E740_WM9705_nAVDD2.
> We should free the these gpio accordingly in e740_exit().
>
> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Liam Girdwood <[email protected]>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

2010-08-20 09:37:07

by Mark Brown

Subject: Re: [PATCH] ASoC: e740_wm9705 - free gpio in e740_exit()

On Thu, Aug 19, 2010 at 02:40:25PM +0800, Axel Lin wrote:
> In e740_init(), we call gpio_request() for
> GPIO_E740_MIC_ON, GPIO_E740_AMP_ON and GPIO_E740_WM9705_nAVDD2.
> We should free the these gpio accordingly in e740_exit().
>
> Signed-off-by: Axel Lin <[email protected]>

Applied, thanks.