2010-08-27 08:34:15

by Axel Lin

Subject: [PATCH] regulator: set max8998->dev to &pdev->dev.

max8998->dev is NULL in current implementation, set it to &pdev->dev.

regulator_register() still return success if max8998->dev is NULL,
but rdev->dev.parent will be set to NULL which is incorrect.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/max8998.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/max8998.c b/drivers/regulator/max8998.c
index 8b9bfdf..a1baf1f 100644
--- a/drivers/regulator/max8998.c
+++ b/drivers/regulator/max8998.c
@@ -557,6 +557,7 @@ static __devinit int max8998_pmic_probe(struct platform_device *pdev)
}

rdev = max8998->rdev;
+ max8998->dev = &pdev->dev;
max8998->iodev = iodev;
max8998->num_regulators = pdata->num_regulators;
platform_set_drvdata(pdev, max8998);
--
1.7.2

2010-08-27 09:30:32

by Mark Brown

Subject: Re: [PATCH] regulator: set max8998->dev to &pdev->dev.

On Fri, Aug 27, 2010 at 04:37:34PM +0800, Axel Lin wrote:
> max8998->dev is NULL in current implementation, set it to &pdev->dev.
>
> regulator_register() still return success if max8998->dev is NULL,
> but rdev->dev.parent will be set to NULL which is incorrect.
>
> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Mark Brown <[email protected]>

2010-08-27 13:04:33

by Liam Girdwood

Subject: Re: [PATCH] regulator: set max8998->dev to &pdev->dev.

On Fri, 2010-08-27 at 10:30 +0100, Mark Brown wrote:
> On Fri, Aug 27, 2010 at 04:37:34PM +0800, Axel Lin wrote:
> > max8998->dev is NULL in current implementation, set it to &pdev->dev.
> >
> > regulator_register() still return success if max8998->dev is NULL,
> > but rdev->dev.parent will be set to NULL which is incorrect.
> >
> > Signed-off-by: Axel Lin <[email protected]>
>
> Acked-by: Mark Brown <[email protected]>
> --
Applied.

Thanks

Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk