2010-11-09 09:03:07

by Axel Lin

Subject: [PATCH] ASoC: Fix compile error if CONFIG_DEBUG_FS is not configured

Add soc_init_card_debugfs and soc_cleanup_card_debugfs functions to fix below error.

CC sound/soc/soc-core.o
sound/soc/soc-core.c: In function 'soc_probe':
sound/soc/soc-core.c:1689: error: implicit declaration of function 'soc_init_card_debugfs'
sound/soc/soc-core.c: In function 'soc_remove':
sound/soc/soc-core.c:1718: error: implicit declaration of function 'soc_cleanup_card_debugfs'
make[2]: *** [sound/soc/soc-core.o] Error 1
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2

Signed-off-by: Axel Lin <[email protected]>
---
sound/soc/soc-core.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index f030521..c18ce1d 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -401,6 +401,14 @@ static inline void soc_init_codec_debugfs(struct snd_soc_codec *codec)
static inline void soc_cleanup_codec_debugfs(struct snd_soc_codec *codec)
{
}
+
+static inline void soc_init_card_debugfs(struct snd_soc_card *card)
+{
+}
+
+static inline void soc_cleanup_card_debugfs(struct snd_soc_card *card)
+{
+}
#endif

#ifdef CONFIG_SND_SOC_AC97_BUS
--
1.7.2

2010-11-09 10:06:58

by Liam Girdwood

Subject: Re: [PATCH] ASoC: Fix compile error if CONFIG_DEBUG_FS is not configured

On Tue, 2010-11-09 at 17:06 +0800, Axel Lin wrote:
> Add soc_init_card_debugfs and soc_cleanup_card_debugfs functions to fix below error.
>
> CC sound/soc/soc-core.o
> sound/soc/soc-core.c: In function 'soc_probe':
> sound/soc/soc-core.c:1689: error: implicit declaration of function 'soc_init_card_debugfs'
> sound/soc/soc-core.c: In function 'soc_remove':
> sound/soc/soc-core.c:1718: error: implicit declaration of function 'soc_cleanup_card_debugfs'
> make[2]: *** [sound/soc/soc-core.o] Error 1
> make[1]: *** [sound/soc] Error 2
> make: *** [sound] Error 2
>
> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Liam Girdwood <[email protected]>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

2010-11-09 17:22:46

by Jarkko Nikula

Subject: Re: [PATCH] ASoC: Fix compile error if CONFIG_DEBUG_FS is not configured

On Tue, 09 Nov 2010 10:01:06 +0000
Liam Girdwood <[email protected]> wrote:

> On Tue, 2010-11-09 at 17:06 +0800, Axel Lin wrote:
> > Add soc_init_card_debugfs and soc_cleanup_card_debugfs functions to fix below error.
> >
> > CC sound/soc/soc-core.o
> > sound/soc/soc-core.c: In function 'soc_probe':
> > sound/soc/soc-core.c:1689: error: implicit declaration of function 'soc_init_card_debugfs'
> > sound/soc/soc-core.c: In function 'soc_remove':
> > sound/soc/soc-core.c:1718: error: implicit declaration of function 'soc_cleanup_card_debugfs'
> > make[2]: *** [sound/soc/soc-core.o] Error 1
> > make[1]: *** [sound/soc] Error 2
> > make: *** [sound] Error 2
> >
> > Signed-off-by: Axel Lin <[email protected]>
>
> Acked-by: Liam Girdwood <[email protected]>
> --
Oops...

Acked-by: Jarkko Nikula <[email protected]>

2010-11-09 17:47:34

by Mark Brown

Subject: Re: [PATCH] ASoC: Fix compile error if CONFIG_DEBUG_FS is not configured

On Tue, Nov 09, 2010 at 05:06:44PM +0800, Axel Lin wrote:
> Add soc_init_card_debugfs and soc_cleanup_card_debugfs functions to fix below error.
>

Applied, thanks.