2010-11-11 00:36:49

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the voltage tree

Hi Liam,

After merging the voltage tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/pcap-regulator.c:155: error: expected declaration specifiers or '...' before 'unsiged'
drivers/regulator/pcap-regulator.c: In function 'pcap_regulator_set_voltage':
drivers/regulator/pcap-regulator.c:175: error: 'selector' undeclared (first use in this function)
drivers/regulator/pcap-regulator.c: At top level:
drivers/regulator/pcap-regulator.c:251: warning: initialization from incompatible pointer type

Caused by commit d2f03ebfe8c63d1e3e1ab2352dd32d161546003e ("regulator:
Report actual configured voltage to set_voltage()"). Please always build
changed files ...

I have used the voltage tree from next-20101110 for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/


Attachments:
(No filename) (861.00 B)
(No filename) (490.00 B)
Download all attachments

2010-11-11 11:46:49

by Mark Brown

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the voltage tree

On Thu, Nov 11, 2010 at 11:36:38AM +1100, Stephen Rothwell wrote:

> After merging the voltage tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Oh, a platform where pcap can actually be built! That's useful, thanks.

> drivers/regulator/pcap-regulator.c:155: error: expected declaration specifiers or '...' before 'unsiged'
> drivers/regulator/pcap-regulator.c: In function 'pcap_regulator_set_voltage':
> drivers/regulator/pcap-regulator.c:175: error: 'selector' undeclared (first use in this function)
> drivers/regulator/pcap-regulator.c: At top level:
> drivers/regulator/pcap-regulator.c:251: warning: initialization from incompatible pointer type

> Caused by commit d2f03ebfe8c63d1e3e1ab2352dd32d161546003e ("regulator:
> Report actual configured voltage to set_voltage()"). Please always build
> changed files ...

With a lot of the embedded drivers that can be difficult - often there
are dependencies on APIs that are only available on a small set of
platforms (which may not even be documented). For example, with PCAP
the core driver uses irq_to_gpio() which is not implemented on any of
the platforms I commonly build for.

2010-11-11 12:09:16

by Liam Girdwood

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the voltage tree

On Thu, 2010-11-11 at 11:46 +0000, Mark Brown wrote:
> On Thu, Nov 11, 2010 at 11:36:38AM +1100, Stephen Rothwell wrote:
>
> > After merging the voltage tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
>
> Oh, a platform where pcap can actually be built! That's useful, thanks.
>
> > drivers/regulator/pcap-regulator.c:155: error: expected declaration specifiers or '...' before 'unsiged'
> > drivers/regulator/pcap-regulator.c: In function 'pcap_regulator_set_voltage':
> > drivers/regulator/pcap-regulator.c:175: error: 'selector' undeclared (first use in this function)
> > drivers/regulator/pcap-regulator.c: At top level:
> > drivers/regulator/pcap-regulator.c:251: warning: initialization from incompatible pointer type
>
> > Caused by commit d2f03ebfe8c63d1e3e1ab2352dd32d161546003e ("regulator:
> > Report actual configured voltage to set_voltage()"). Please always build
> > changed files ...
>
> With a lot of the embedded drivers that can be difficult - often there
> are dependencies on APIs that are only available on a small set of
> platforms (which may not even be documented). For example, with PCAP
> the core driver uses irq_to_gpio() which is not implemented on any of
> the platforms I commonly build for.
> --

Fix now applied.

Thanks

Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk