2010-11-30 01:40:23

by Axel Lin

Subject: [PATCH] ASoC: Fix compile error for s6000-i2s.c by adding a missing ';' character

Signed-off-by: Axel Lin <[email protected]>
---
I don't have toolchain to compile s6000, I'm not able to put the error message in the commit log.
But I know this patch indeed fixes a compile error.

sound/soc/s6000/s6000-i2s.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/s6000/s6000-i2s.c b/sound/soc/s6000/s6000-i2s.c
index 8778faa..3052f64 100644
--- a/sound/soc/s6000/s6000-i2s.c
+++ b/sound/soc/s6000/s6000-i2s.c
@@ -434,7 +434,7 @@ static struct snd_soc_dai_driver s6000_i2s_dai = {
.rate_max = 1562500,
},
.ops = &s6000_i2s_dai_ops,
-}
+};

static int __devinit s6000_i2s_probe(struct platform_device *pdev)
{
--
1.7.2

2010-11-30 11:22:53

by Liam Girdwood

Subject: Re: [PATCH] ASoC: Fix compile error for s6000-i2s.c by adding a missing ';' character

On Tue, 2010-11-30 at 09:45 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <[email protected]>
> ---
> I don't have toolchain to compile s6000, I'm not able to put the error message in the commit log.
> But I know this patch indeed fixes a compile error.
>
> sound/soc/s6000/s6000-i2s.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/s6000/s6000-i2s.c b/sound/soc/s6000/s6000-i2s.c
> index 8778faa..3052f64 100644
> --- a/sound/soc/s6000/s6000-i2s.c
> +++ b/sound/soc/s6000/s6000-i2s.c
> @@ -434,7 +434,7 @@ static struct snd_soc_dai_driver s6000_i2s_dai = {
> .rate_max = 1562500,
> },
> .ops = &s6000_i2s_dai_ops,
> -}
> +};
>
> static int __devinit s6000_i2s_probe(struct platform_device *pdev)
> {

I think Daniel was first so I've acked his patch for this.

Thanks

Liam

--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

2010-11-30 11:24:50

by Mark Brown

Subject: Re: [PATCH] ASoC: Fix compile error for s6000-i2s.c by adding a missing ';' character

On Tue, Nov 30, 2010 at 09:45:53AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <[email protected]>
> ---
> I don't have toolchain to compile s6000, I'm not able to put the error message in the commit log.
> But I know this patch indeed fixes a compile error.

Daniel already posted the same patch (and a bunch of others), just
waiting for Liam's review. The S6000 port as a whole doesn't compile
anyway at the minute (due to arch/ side issues).