2011-02-03 23:19:07

by Rhyland Klein

[permalink] [raw]
Subject: Re: [PATCH v3] power: bq20z75: add support for charge properties

On Mon, 2011-01-31 at 05:19 -0800, Anton Vorontsov wrote:
> On Tue, Jan 25, 2011 at 11:10:06AM -0800, [email protected] wrote:
> > From: Rhyland Klein <[email protected]>
> >
> > Adding support for charge properties for gas gauge.
> > Also ensuring that battery mode is correct now for energy as well as
> > charge properties by setting it on the fly.
> >
> > I also added 2 functions to power_supply.h to help identify the units for
> > specific properties more easily by power supplies.
> >
> > Signed-off-by: Rhyland Klein <[email protected]>
> > ---
>
> Applied with some cosmetic changes.
>
> [...]
> > +static inline bool power_supply_is_amp_property(
> > + enum power_supply_property psp){
>
> Fixed style issues here.
>
> [...]
> > +static inline bool power_supply_is_watt_property(
> > + enum power_supply_property psp){
>
> And here.
>
> Thanks!
>

Anton, I looked at linux-next.git and battery-2.6.git but i don't see
this latest version anywhere, is there a different git this was pushed
to?

-rhyland


2011-02-04 07:12:56

by Anton Vorontsov

[permalink] [raw]
Subject: Re: [PATCH v3] power: bq20z75: add support for charge properties

On Thu, Feb 03, 2011 at 03:18:43PM -0800, rklein wrote:
> On Mon, 2011-01-31 at 05:19 -0800, Anton Vorontsov wrote:
> > On Tue, Jan 25, 2011 at 11:10:06AM -0800, [email protected] wrote:
> > > From: Rhyland Klein <[email protected]>
> > >
> > > Adding support for charge properties for gas gauge.
> > > Also ensuring that battery mode is correct now for energy as well as
> > > charge properties by setting it on the fly.
> > >
> > > I also added 2 functions to power_supply.h to help identify the units for
> > > specific properties more easily by power supplies.
> > >
> > > Signed-off-by: Rhyland Klein <[email protected]>
> > > ---
> >
> > Applied with some cosmetic changes.
> >
> > [...]
> > > +static inline bool power_supply_is_amp_property(
> > > + enum power_supply_property psp){
> >
> > Fixed style issues here.
> >
> > [...]
> > > +static inline bool power_supply_is_watt_property(
> > > + enum power_supply_property psp){
> >
> > And here.
> >
> > Thanks!
> >
>
> Anton, I looked at linux-next.git and battery-2.6.git but i don't see
> this latest version anywhere, is there a different git this was pushed
> to?

Hmm. I see it here:

http://git.infradead.org/battery-2.6.git/commitdiff/51d07566045787b99219d809639c8724506fc78a

Thanks,

--
Anton Vorontsov
Email: [email protected]

2011-02-04 18:24:38

by Rhyland Klein

[permalink] [raw]
Subject: Re: [PATCH v3] power: bq20z75: add support for charge properties

On Thu, 2011-02-03 at 23:12 -0800, Anton Vorontsov wrote:
> On Thu, Feb 03, 2011 at 03:18:43PM -0800, rklein wrote:
> > On Mon, 2011-01-31 at 05:19 -0800, Anton Vorontsov wrote:
> > > On Tue, Jan 25, 2011 at 11:10:06AM -0800, [email protected] wrote:
> > > > From: Rhyland Klein <[email protected]>
> > > >
> > > > Adding support for charge properties for gas gauge.
> > > > Also ensuring that battery mode is correct now for energy as well as
> > > > charge properties by setting it on the fly.
> > > >
> > > > I also added 2 functions to power_supply.h to help identify the units for
> > > > specific properties more easily by power supplies.
> > > >
> > > > Signed-off-by: Rhyland Klein <[email protected]>
> > > > ---
> > >
> > > Applied with some cosmetic changes.
> > >
> > > [...]
> > > > +static inline bool power_supply_is_amp_property(
> > > > + enum power_supply_property psp){
> > >
> > > Fixed style issues here.
> > >
> > > [...]
> > > > +static inline bool power_supply_is_watt_property(
> > > > + enum power_supply_property psp){
> > >
> > > And here.
> > >
> > > Thanks!
> > >
> >
> > Anton, I looked at linux-next.git and battery-2.6.git but i don't see
> > this latest version anywhere, is there a different git this was pushed
> > to?
>
> Hmm. I see it here:
>
> http://git.infradead.org/battery-2.6.git/commitdiff/51d07566045787b99219d809639c8724506fc78a
>
> Thanks,
>

Hmm, i see it now, thanks!