2011-03-24 20:37:42

by Thomas Gleixner

Subject: [PATCH] xen: Use new irq_move functions

These functions take irq_data as an argument and avoid a redundant
lookup in the sparse irq case.

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Ian Campbell <[email protected]>
Cc: Jeremy Fitzhardinge <[email protected]>
Cc: Konrad Rzeszutek Wilk <[email protected]>
---
drivers/xen/events.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6-tip/drivers/xen/events.c
===================================================================
--- linux-2.6-tip.orig/drivers/xen/events.c
+++ linux-2.6-tip/drivers/xen/events.c
@@ -585,7 +585,7 @@ static void ack_pirq(struct irq_data *da
{
int evtchn = evtchn_from_irq(data->irq);

- move_native_irq(data->irq);
+ irq_move_irq(data);

if (VALID_EVTCHN(evtchn)) {
mask_evtchn(evtchn);
@@ -1339,7 +1339,7 @@ static void ack_dynirq(struct irq_data *
{
int evtchn = evtchn_from_irq(data->irq);

- move_masked_irq(data->irq);
+ irq_move_masked_irq(data);

if (VALID_EVTCHN(evtchn))
unmask_evtchn(evtchn);

2011-03-25 10:04:09

by Ian Campbell

Subject: Re: [PATCH] xen: Use new irq_move functions

On Thu, 2011-03-24 at 20:37 +0000, Thomas Gleixner wrote:
> These functions take irq_data as an argument and avoid a redundant
> lookup in the sparse irq case.
>
> Signed-off-by: Thomas Gleixner <[email protected]>

Looks good to me.

Acked-by: Ian Campbell <[email protected]>

Do you want to carry this in your tree or shall we pick it up? (not sure
if this is part of a wider treewide series or not)

> Cc: Jeremy Fitzhardinge <[email protected]>
> Cc: Konrad Rzeszutek Wilk <[email protected]>
> ---
> drivers/xen/events.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6-tip/drivers/xen/events.c
> ===================================================================
> --- linux-2.6-tip.orig/drivers/xen/events.c
> +++ linux-2.6-tip/drivers/xen/events.c
> @@ -585,7 +585,7 @@ static void ack_pirq(struct irq_data *da
> {
> int evtchn = evtchn_from_irq(data->irq);
>
> - move_native_irq(data->irq);
> + irq_move_irq(data);
>
> if (VALID_EVTCHN(evtchn)) {
> mask_evtchn(evtchn);
> @@ -1339,7 +1339,7 @@ static void ack_dynirq(struct irq_data *
> {
> int evtchn = evtchn_from_irq(data->irq);
>
> - move_masked_irq(data->irq);
> + irq_move_masked_irq(data);
>
> if (VALID_EVTCHN(evtchn))
> unmask_evtchn(evtchn);

2011-03-25 11:54:20

by Thomas Gleixner

Subject: Re: [PATCH] xen: Use new irq_move functions

On Fri, 25 Mar 2011, Ian Campbell wrote:

> On Thu, 2011-03-24 at 20:37 +0000, Thomas Gleixner wrote:
> > These functions take irq_data as an argument and avoid a redundant
> > lookup in the sparse irq case.
> >
> > Signed-off-by: Thomas Gleixner <[email protected]>
>
> Looks good to me.
>
> Acked-by: Ian Campbell <[email protected]>
>
> Do you want to carry this in your tree or shall we pick it up? (not sure
> if this is part of a wider treewide series or not)

Works either way as long as we get it into .39 so we can cleanup the
old stuff. Ditto for the namespace.

Thanks,

tglx

2011-03-25 12:23:52

by Konrad Rzeszutek Wilk

Subject: Re: [PATCH] xen: Use new irq_move functions

On Fri, Mar 25, 2011 at 12:54:09PM +0100, Thomas Gleixner wrote:
> On Fri, 25 Mar 2011, Ian Campbell wrote:
>
> > On Thu, 2011-03-24 at 20:37 +0000, Thomas Gleixner wrote:
> > > These functions take irq_data as an argument and avoid a redundant
> > > lookup in the sparse irq case.
> > >
> > > Signed-off-by: Thomas Gleixner <[email protected]>
> >
> > Looks good to me.
> >
> > Acked-by: Ian Campbell <[email protected]>
> >
> > Do you want to carry this in your tree or shall we pick it up? (not sure
> > if this is part of a wider treewide series or not)
>
> Works either way as long as we get it into .39 so we can cleanup the
> old stuff. Ditto for the namespace.

I will take them and push them out next week.