2011-04-07 14:36:55

by Justin P. Mattock

Subject: [PATCH]drivers:staging:hv:hv_mouse.c Fix build error in hv_mouse.

The patch below fixes a build error..

LD [M] drivers/staging/hv/hv_utils.o
CC [M] drivers/staging/hv/hv_mouse.o
drivers/staging/hv/hv_mouse.c: In function ‘ReleaseInputDevice’:
drivers/staging/hv/hv_mouse.c:293:3: error: implicit declaration of function ‘udelay’ [-Werror=implicit-function-declaration]
drivers/staging/hv/hv_mouse.c: In function ‘MousevscOnReceiveInputReport’:
drivers/staging/hv/hv_mouse.c:418:27: warning: variable ‘inputDriver’ set but not used [-Wunused-but-set-variable]
drivers/staging/hv/hv_mouse.c: In function ‘MousevscOnDeviceAdd’:
drivers/staging/hv/hv_mouse.c:663:27: warning: variable ‘inputDriver’ set but not used [-Wunused-but-set-variable]
cc1: some warnings being treated as errors

Signed-off-by: Justin P. Mattock <[email protected]>

---
drivers/staging/hv/hv_mouse.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
index 50147f8..9c6d4d2 100644
--- a/drivers/staging/hv/hv_mouse.c
+++ b/drivers/staging/hv/hv_mouse.c
@@ -23,6 +23,7 @@
#include <linux/hiddev.h>
#include <linux/pci.h>
#include <linux/dmi.h>
+#include <linux/delay.h>

#include "hv_api.h"
#include "logging.h"
--
1.7.4.2

2011-04-07 16:31:57

by Greg KH

Subject: Re: [PATCH]drivers:staging:hv:hv_mouse.c Fix build error in hv_mouse.

On Thu, Apr 07, 2011 at 07:36:36AM -0700, Justin P. Mattock wrote:
> The patch below fixes a build error..
>
> LD [M] drivers/staging/hv/hv_utils.o
> CC [M] drivers/staging/hv/hv_mouse.o
> drivers/staging/hv/hv_mouse.c: In function ‘ReleaseInputDevice’:
> drivers/staging/hv/hv_mouse.c:293:3: error: implicit declaration of function ‘udelay’ [-Werror=implicit-function-declaration]
> drivers/staging/hv/hv_mouse.c: In function ‘MousevscOnReceiveInputReport’:
> drivers/staging/hv/hv_mouse.c:418:27: warning: variable ‘inputDriver’ set but not used [-Wunused-but-set-variable]
> drivers/staging/hv/hv_mouse.c: In function ‘MousevscOnDeviceAdd’:
> drivers/staging/hv/hv_mouse.c:663:27: warning: variable ‘inputDriver’ set but not used [-Wunused-but-set-variable]
> cc1: some warnings being treated as errors
>
> Signed-off-by: Justin P. Mattock <[email protected]>
>
> ---
> drivers/staging/hv/hv_mouse.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, but this is already in the linux-next tree and will go to Linus
in a few hours.

greg k-h

2011-04-07 16:37:19

by Justin P. Mattock

Subject: Re: [PATCH]drivers:staging:hv:hv_mouse.c Fix build error in hv_mouse.

On 04/07/2011 09:22 AM, Greg KH wrote:
> On Thu, Apr 07, 2011 at 07:36:36AM -0700, Justin P. Mattock wrote:
>> The patch below fixes a build error..
>>
>> LD [M] drivers/staging/hv/hv_utils.o
>> CC [M] drivers/staging/hv/hv_mouse.o
>> drivers/staging/hv/hv_mouse.c: In function ‘ReleaseInputDevice’:
>> drivers/staging/hv/hv_mouse.c:293:3: error: implicit declaration of function ‘udelay’ [-Werror=implicit-function-declaration]
>> drivers/staging/hv/hv_mouse.c: In function ‘MousevscOnReceiveInputReport’:
>> drivers/staging/hv/hv_mouse.c:418:27: warning: variable ‘inputDriver’ set but not used [-Wunused-but-set-variable]
>> drivers/staging/hv/hv_mouse.c: In function ‘MousevscOnDeviceAdd’:
>> drivers/staging/hv/hv_mouse.c:663:27: warning: variable ‘inputDriver’ set but not used [-Wunused-but-set-variable]
>> cc1: some warnings being treated as errors
>>
>> Signed-off-by: Justin P. Mattock<[email protected]>
>>
>> ---
>> drivers/staging/hv/hv_mouse.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> Thanks, but this is already in the linux-next tree and will go to Linus
> in a few hours.
>
> greg k-h
>


alright... no worries!!

Justin P. Mattock