2011-06-28 09:44:06

by Alexander Stein

Subject: [PATCH] i2c-eg20t: Do not print error message if no ACK is received

Doing so would spam the kernel log for each i2cdetect run and
device probe.

Signed-off-by: Alexander Stein <[email protected]>
---
drivers/i2c/busses/i2c-eg20t.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
index 8abfa4a..97110f7 100644
--- a/drivers/i2c/busses/i2c-eg20t.c
+++ b/drivers/i2c/busses/i2c-eg20t.c
@@ -345,7 +345,7 @@ static s32 pch_i2c_getack(struct i2c_algo_pch_data *adap)
reg_val = ioread32(p + PCH_I2CSR) & PCH_GETACK;

if (reg_val != 0) {
- pch_err(adap, "return%d\n", -EPROTO);
+ pch_dbg(adap, "return%d\n", -EPROTO);
return -EPROTO;
}

--
1.7.3.4

2011-06-28 10:20:22

by Christian Gmeiner

Subject: Re: [PATCH] i2c-eg20t: Do not print error message if no ACK is received

Acked-by: Christian Gmeiner <[email protected]>
--
Christian Gmeiner, MSc

2011-06-28 21:52:13

by Ben Dooks

Subject: Re: [PATCH] i2c-eg20t: Do not print error message if no ACK is received

On Tue, Jun 28, 2011 at 11:43:39AM +0200, Alexander Stein wrote:
> Doing so would spam the kernel log for each i2cdetect run and
> device probe.
>
> Signed-off-by: Alexander Stein <[email protected]>

ok, will add to fixes for -rc.

> ---
> drivers/i2c/busses/i2c-eg20t.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
> index 8abfa4a..97110f7 100644
> --- a/drivers/i2c/busses/i2c-eg20t.c
> +++ b/drivers/i2c/busses/i2c-eg20t.c
> @@ -345,7 +345,7 @@ static s32 pch_i2c_getack(struct i2c_algo_pch_data *adap)
> reg_val = ioread32(p + PCH_I2CSR) & PCH_GETACK;
>
> if (reg_val != 0) {
> - pch_err(adap, "return%d\n", -EPROTO);
> + pch_dbg(adap, "return%d\n", -EPROTO);
> return -EPROTO;
> }
>
> --
> 1.7.3.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Ben Dooks, [email protected], http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.