2012-08-06 12:29:37

by Cong Wang

Subject: [Patch] string: do not export memweight() to userspace

From: WANG Cong <[email protected]>

This patch fixes the following warning:

usr/include/linux/string.h:8: userspace cannot reference function or variable defined in the kernel

Cc: Akinobu Mita <[email protected]>
Signed-off-by: WANG Cong <[email protected]>

---
diff --git a/include/linux/string.h b/include/linux/string.h
index ffe0442..b917881 100644
--- a/include/linux/string.h
+++ b/include/linux/string.h
@@ -144,8 +144,8 @@ static inline bool strstarts(const char *str, const char *prefix)
{
return strncmp(str, prefix, strlen(prefix)) == 0;
}
-#endif

extern size_t memweight(const void *ptr, size_t bytes);

+#endif /* __KERNEL__ */
#endif /* _LINUX_STRING_H_ */

2012-08-06 12:40:49

by Akinobu Mita

Subject: Re: [Patch] string: do not export memweight() to userspace

2012/8/6 Cong Wang <[email protected]>:
> From: WANG Cong <[email protected]>
>
> This patch fixes the following warning:
>
> usr/include/linux/string.h:8: userspace cannot reference function or variable defined in the kernel

Thanks for finding this problem.
Looks good to me.

> Cc: Akinobu Mita <[email protected]>
> Signed-off-by: WANG Cong <[email protected]>
>
> ---
> diff --git a/include/linux/string.h b/include/linux/string.h
> index ffe0442..b917881 100644
> --- a/include/linux/string.h
> +++ b/include/linux/string.h
> @@ -144,8 +144,8 @@ static inline bool strstarts(const char *str, const char *prefix)
> {
> return strncmp(str, prefix, strlen(prefix)) == 0;
> }
> -#endif
>
> extern size_t memweight(const void *ptr, size_t bytes);
>
> +#endif /* __KERNEL__ */
> #endif /* _LINUX_STRING_H_ */