2012-08-15 00:57:21

by Alex Shi

Subject: Re: [tip:auto-latest 18/37] kernel/sched/core.c:6460:1: error: 'SD_PREFER_LOCAL' undeclared (first use in this function)

On 08/15/2012 04:36 AM, Fengguang Wu wrote:

> Hi Alex,
>
> FYI, kernel build failed on
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git auto-latest
> head: e42942691c8262b7fe2a7b88577623082b988217
> commit: f03542a7019c600163ac4441d8a826c92c1bd510 [18/37] sched: recover SD_WAKE_AFFINE in select_task_rq_fair and code clean up
> config: tile-tilegx_defconfig (attached as .config)
>
> All related error/warning messages:
>
> kernel/sched/core.c: In function 'sd_init_CPU':
> kernel/sched/core.c:6460:1: error: 'SD_PREFER_LOCAL' undeclared (first use in this function)
> kernel/sched/core.c:6460:1: note: each undeclared identifier is reported only once for each function it appears in
>


Sorry for this mistaken!
The following is fixing patch

============
>From 033c87bfde319e7b0bdd090a76e5731930332c41 Mon Sep 17 00:00:00 2001
From: Alex Shi <[email protected]>
Date: Wed, 15 Aug 2012 08:14:36 +0800
Subject: [PATCH] sched: remove SD_PREFER_LOCAL in tile arch

commit (sched: recover SD_WAKE_AFFINE in select_task_rq_fair and code
clean up) remove SD_PREFER_LOCAL definition, but left a SD_PREFER_LOCAL
usage in tile arch code. That cause tile arch out of work.

This patch removes the died code from tile arch.

Reported-by: Fengguang Wu <[email protected]>
Signed-off-by: Alex Shi <[email protected]>
---
arch/tile/include/asm/topology.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/tile/include/asm/topology.h b/arch/tile/include/asm/topology.h
index 7a7ce39..d5e86c9 100644
--- a/arch/tile/include/asm/topology.h
+++ b/arch/tile/include/asm/topology.h
@@ -69,7 +69,6 @@ static inline const struct cpumask *cpumask_of_node(int node)
| 1*SD_BALANCE_FORK \
| 0*SD_BALANCE_WAKE \
| 0*SD_WAKE_AFFINE \
- | 0*SD_PREFER_LOCAL \
| 0*SD_SHARE_CPUPOWER \
| 0*SD_SHARE_PKG_RESOURCES \
| 0*SD_SERIALIZE \
--
1.7.5.4

2012-08-15 08:22:05

by Peter Zijlstra

Subject: Re: [tip:auto-latest 18/37] kernel/sched/core.c:6460:1: error: 'SD_PREFER_LOCAL' undeclared (first use in this function)

On Wed, 2012-08-15 at 08:57 +0800, Alex Shi wrote:
> Sorry for this mistaken!
> The following is fixing patch
>
Thanks!

2012-08-15 11:29:21

by Alex Shi

Subject: [tip:sched/core] tile: Remove SD_PREFER_LOCAL leftover

Commit-ID: c7660994ed6b44d17dad0aac0d156da1e0a2f003
Gitweb: http://git.kernel.org/tip/c7660994ed6b44d17dad0aac0d156da1e0a2f003
Author: Alex Shi <[email protected]>
AuthorDate: Wed, 15 Aug 2012 08:14:36 +0800
Committer: Thomas Gleixner <[email protected]>
CommitDate: Wed, 15 Aug 2012 13:22:55 +0200

tile: Remove SD_PREFER_LOCAL leftover

commit (sched: recover SD_WAKE_AFFINE in select_task_rq_fair and code
clean up) removed SD_PREFER_LOCAL, but left a SD_PREFER_LOCAL usage in
arch/tile code. That breaks the arch/tile build.

Reported-by: Fengguang Wu <[email protected]>
Signed-off-by: Alex Shi <[email protected]>
Acked-by: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>
---
arch/tile/include/asm/topology.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/tile/include/asm/topology.h b/arch/tile/include/asm/topology.h
index 7a7ce39..d5e86c9 100644
--- a/arch/tile/include/asm/topology.h
+++ b/arch/tile/include/asm/topology.h
@@ -69,7 +69,6 @@ static inline const struct cpumask *cpumask_of_node(int node)
| 1*SD_BALANCE_FORK \
| 0*SD_BALANCE_WAKE \
| 0*SD_WAKE_AFFINE \
- | 0*SD_PREFER_LOCAL \
| 0*SD_SHARE_CPUPOWER \
| 0*SD_SHARE_PKG_RESOURCES \
| 0*SD_SERIALIZE \