2012-10-18 16:53:39

by Sangho Yi

Subject: [PATCH 1/2] mmc: core: sdio_cis.c: Fixed pointer casting coding style error

I fixed the following two kinds of errors on coding style.
ERROR: "(foo*)" should be "(foo *)"
ERROR: "(foo**)" should be "(foo **)"

Signed-off-by: Sangho Yi <[email protected]>
---
drivers/mmc/core/sdio_cis.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/core/sdio_cis.c b/drivers/mmc/core/sdio_cis.c
index 8e94e55..e4221df 100644
--- a/drivers/mmc/core/sdio_cis.c
+++ b/drivers/mmc/core/sdio_cis.c
@@ -47,11 +47,11 @@ static int cistpl_vers_1(struct mmc_card *card, struct sdio_func *func,

size = i;

- buffer = kzalloc(sizeof(char*) * nr_strings + size, GFP_KERNEL);
+ buffer = kzalloc(sizeof(char *) * nr_strings + size, GFP_KERNEL);
if (!buffer)
return -ENOMEM;

- string = (char*)(buffer + nr_strings);
+ string = (char *)(buffer + nr_strings);

for (i = 0; i < nr_strings; i++) {
buffer[i] = string;
@@ -62,10 +62,10 @@ static int cistpl_vers_1(struct mmc_card *card, struct sdio_func *func,

if (func) {
func->num_info = nr_strings;
- func->info = (const char**)buffer;
+ func->info = (const char **)buffer;
} else {
card->num_info = nr_strings;
- card->info = (const char**)buffer;
+ card->info = (const char **)buffer;
}

return 0;
--
1.7.9.5

2012-10-18 16:53:44

by Sangho Yi

Subject: [PATCH 2/2] mmc: core: sdio_cis.c: Fixed the position of opening braces {

I fixed the following coding style error:
ERROR: that open brace { should be on the previous line

Signed-off-by: Sangho Yi <[email protected]>
---
drivers/mmc/core/sdio_cis.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/core/sdio_cis.c b/drivers/mmc/core/sdio_cis.c
index e4221df..c81cda3 100644
--- a/drivers/mmc/core/sdio_cis.c
+++ b/drivers/mmc/core/sdio_cis.c
@@ -93,11 +93,10 @@ static int cistpl_manfid(struct mmc_card *card, struct sdio_func *func,
return 0;
}

-static const unsigned char speed_val[16] =
- { 0, 10, 12, 13, 15, 20, 25, 30, 35, 40, 45, 50, 55, 60, 70, 80 };
-static const unsigned int speed_unit[8] =
- { 10000, 100000, 1000000, 10000000, 0, 0, 0, 0 };
-
+static const unsigned char speed_val[16] = { 0, 10, 12, 13, 15, 20, 25, 30, 35,
+ 40, 45, 50, 55, 60, 70, 80 };
+static const unsigned int speed_unit[8] = { 10000, 100000, 1000000, 10000000,
+ 0, 0, 0, 0 };

typedef int (tpl_parse_t)(struct mmc_card *, struct sdio_func *,
const unsigned char *, unsigned);
--
1.7.9.5