2012-10-19 13:59:20

by Sangho Yi

Subject: [PATCH 1/2] mmc: core: bus.c: removed unnecessary NULL check for kfree(...)

kfree(NULL) is safe so I removed the if statements for NULL check.

Signed-off-by: Sangho Yi <[email protected]>
---
drivers/mmc/core/bus.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
index 9b68933..420cb67 100644
--- a/drivers/mmc/core/bus.c
+++ b/drivers/mmc/core/bus.c
@@ -225,8 +225,7 @@ static void mmc_release_card(struct device *dev)

sdio_free_common_cis(card);

- if (card->info)
- kfree(card->info);
+ kfree(card->info);

kfree(card);
}
--
1.7.9.5

2012-10-19 13:59:26

by Sangho Yi

Subject: [PATCH 2/2] mmc: core: bus.c: re-aligned the line over 80 chars

I made a correction on a line which has > 80 characters
also, aligned the consecutive line to meet the --strict rule.

Signed-off-by: Sangho Yi <[email protected]>
---
drivers/mmc/core/bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
index 420cb67..66bac9f 100644
--- a/drivers/mmc/core/bus.c
+++ b/drivers/mmc/core/bus.c
@@ -269,8 +269,8 @@ int mmc_add_card(struct mmc_card *card)
[UHS_DDR50_BUS_SPEED] = "DDR50 ",
};

-
- dev_set_name(&card->dev, "%s:%04x", mmc_hostname(card->host), card->rca);
+ dev_set_name(&card->dev, "%s:%04x", mmc_hostname(card->host),
+ card->rca);

switch (card->type) {
case MMC_TYPE_MMC:
--
1.7.9.5

2012-10-19 14:54:00

by Philip Rakity

Subject: Re: [PATCH 1/2] mmc: core: bus.c: removed unnecessary NULL check for kfree(...)

On 19 Oct 2012, at 14:58, Sangho Yi <[email protected]> wrote:

> kfree(NULL) is safe so I removed the if statements for NULL check.
>
> Signed-off-by: Sangho Yi <[email protected]>
> ---
> drivers/mmc/core/bus.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
> index 9b68933..420cb67 100644
> --- a/drivers/mmc/core/bus.c
> +++ b/drivers/mmc/core/bus.c
> @@ -225,8 +225,7 @@ static void mmc_release_card(struct device *dev)
>
> sdio_free_common_cis(card);
>
> - if (card->info)
> - kfree(card->info);
> + kfree(card->info);
>
> kfree(card);
> }
> --
> 1.7.9.5

Reviewed-by: Philip Rakity <[email protected]>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html